Skip to content

Client log does not store info about exceptions during download/pull/push #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wonder-sk opened this issue Jan 6, 2023 · 0 comments · Fixed by #182
Closed

Client log does not store info about exceptions during download/pull/push #156

wonder-sk opened this issue Jan 6, 2023 · 0 comments · Fixed by #182
Assignees
@alexbruy
Labels
bug Something isn't working

Comments

@wonder-sk
Copy link
Contributor

Currently if there is an unhandled exception while e.g. downloading, it is not added to the log - this makes logs less useful...

To simulate, one can add an invalid statement to download_blocking() function.
@wonder-sk wonder-sk added the bug Something isn't working label Jan 6, 2023
@wonder-sk wonder-sk assigned JanCaha and alexbruy and unassigned JanCaha Oct 10, 2023
alexbruy added a commit that referenced this issue Oct 12, 2023
@alexbruy
log errors when project download fails (refs #156)
a547664
alexbruy added a commit that referenced this issue Oct 12, 2023
@alexbruy
log errors when project download fails (refs #156)
f8e9746
@alexbruy alexbruy mentioned this issue Oct 12, 2023
Closed
alexbruy added a commit that referenced this issue Oct 16, 2023
@alexbruy
log errors when project download fails (refs #156)
710f1b6
@wonder-sk wonder-sk mentioned this issue Oct 26, 2023
Merged
alexbruy added a commit that referenced this issue Oct 29, 2023
@alexbruy
log errors when project download fails (refs #156)
34bde7d
wonder-sk pushed a commit that referenced this issue Oct 30, 2023
@alexbruy
Keep log file of failed downloads + add exceptions to the log (#182)
f555e71 
* copy log file to the temp dir before removing project directory if
download fails

* address review

* codestyle

* add active waiting test

* log errors when project download fails (refs #156)

* write traceback to the log
check that traceback present in the log in test

* formatting

* address review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbruy alexbruy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

copy log file to the temp dir before removing project directory MerginMaps/python-api-client
3 participants
@wonder-sk @alexbruy @JanCaha