Skip to content

Resolve peer dependency warnings in core #4906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcmire opened this issue Nov 7, 2024 · 0 comments · Fixed by #4974
Closed

Resolve peer dependency warnings in core #4906

mcmire opened this issue Nov 7, 2024 · 0 comments · Fixed by #4974
Assignees

Comments

@mcmire
Copy link
Contributor

mcmire commented Nov 7, 2024

As of 11/7/2024, the following peer dependency warnings show when running yarn install:

➤ YN0060: │ typescript is listed by your project with version 5.2.2, which doesn't satisfy what ts-jest (p39146) and other dependencies request (~4.8.4).
➤ YN0002: │ @metamask/accounts-controller@workspace:packages/accounts-controller [cbb75] doesn't provide @metamask/providers (pd554a), requested by @metamask/keyring-api.
➤ YN0002: │ @metamask/accounts-controller@workspace:packages/accounts-controller [d7116] doesn't provide @metamask/providers (p3d68d), requested by @metamask/keyring-api.
➤ YN0002: │ @metamask/accounts-controller@workspace:packages/accounts-controller doesn't provide @metamask/providers (pb6f8b), requested by @metamask/keyring-api.
➤ YN0002: │ @metamask/assets-controllers@workspace:packages/assets-controllers doesn't provide @babel/runtime (pb0379), requested by @metamask/ethjs-provider-http.
➤ YN0002: │ @metamask/assets-controllers@workspace:packages/assets-controllers doesn't provide @metamask/providers (p27414), requested by @metamask/keyring-api.
➤ YN0002: │ @metamask/chain-controller@workspace:packages/chain-controller doesn't provide @metamask/providers (p41677), requested by @metamask/keyring-api.
➤ YN0002: │ @metamask/controller-utils@workspace:packages/controller-utils doesn't provide @babel/runtime (pc9ce5), requested by @metamask/ethjs-unit.
➤ YN0002: │ @metamask/core-monorepo@workspace:. doesn't provide @lavamoat/preinstall-always-fail (p62767), requested by @lavamoat/allow-scripts.
➤ YN0002: │ @metamask/gas-fee-controller@workspace:packages/gas-fee-controller [58cb1] doesn't provide @babel/runtime (p57aff), requested by @metamask/ethjs-unit.
➤ YN0002: │ @metamask/gas-fee-controller@workspace:packages/gas-fee-controller doesn't provide @babel/runtime (p7ed46), requested by @metamask/ethjs-unit.
➤ YN0002: │ @metamask/json-rpc-engine@workspace:packages/json-rpc-engine doesn't provide @lavamoat/preinstall-always-fail (p97a7f), requested by @lavamoat/allow-scripts.
➤ YN0002: │ @metamask/keyring-controller@workspace:packages/keyring-controller doesn't provide @lavamoat/preinstall-always-fail (p61a02), requested by @lavamoat/allow-scripts.
➤ YN0002: │ @metamask/keyring-controller@workspace:packages/keyring-controller doesn't provide @metamask/providers (pfc9e1), requested by @metamask/keyring-api.
➤ YN0002: │ @metamask/notification-services-controller@workspace:packages/notification-services-controller doesn't provide @lavamoat/preinstall-always-fail (pf9e18), requested by @lavamoat/allow-scripts.
➤ YN0002: │ @metamask/profile-sync-controller@workspace:packages/profile-sync-controller [7f019] doesn't provide @lavamoat/preinstall-always-fail (p24ce9), requested by @lavamoat/allow-scripts.
➤ YN0002: │ @metamask/profile-sync-controller@workspace:packages/profile-sync-controller [7f019] doesn't provide @metamask/providers (p3aaa4), requested by @metamask/keyring-api.
➤ YN0002: │ @metamask/profile-sync-controller@workspace:packages/profile-sync-controller doesn't provide @lavamoat/preinstall-always-fail (p54887), requested by @lavamoat/allow-scripts.
➤ YN0002: │ @metamask/profile-sync-controller@workspace:packages/profile-sync-controller doesn't provide @metamask/providers (p0a402), requested by @metamask/keyring-api.
➤ YN0002: │ @metamask/transaction-controller@workspace:packages/transaction-controller [53fb6] doesn't provide @metamask/eth-block-tracker (pbb274), requested by @metamask/nonce-tracker.
➤ YN0002: │ @metamask/transaction-controller@workspace:packages/transaction-controller [53fb6] doesn't provide @metamask/providers (p384d6), requested by @metamask/keyring-api.
➤ YN0002: │ @metamask/transaction-controller@workspace:packages/transaction-controller doesn't provide @metamask/eth-block-tracker (pb4f88), requested by @metamask/nonce-tracker.
➤ YN0002: │ @metamask/transaction-controller@workspace:packages/transaction-controller doesn't provide @metamask/providers (pac5e4), requested by @metamask/keyring-api.

We should seek to have 0 peer dependency warnings in this repo.

Acceptance Criteria

  • When running yarn install, no peer dependency warnings are shown.
@mcmire mcmire self-assigned this Nov 25, 2024
@desi desi changed the title Resolve peer dependency warnings Resolve peer dependency warnings in core Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant