Fix peer dependency warnings

[mcmire]

Explanation

When running yarn install, several packages generate peer dependency warnings.

• @lavamoat/preinstall-always-fail is now a peer dependency of @lavamoat/allow-scripts, so we need to add it as a new dev dependency.
• For the other packages — @babel/runtime, @metamask/providers, webextension-polyfill — we really expect the client to have these dependencies, so we also add them as dev and peer dependencies instead of dependencies. We have to do this because they will not get forwarded along.

References

Fixes #4906.

Changelog

Changes are documented in changelogs.

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@lavamoat/preinstall-always-fail@2.1.0	None	0	3.53 kB	lmbot

View full report↗︎

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@lavamoat/preinstall-always-fail@2.1.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

[mcmire]

@SocketSecurity ignore npm/@lavamoat/preinstall-always-fail@2.1.0

New author is OK.

Install script is expected.

[Gudahtt]

Mostly looks good! Just the babel/runtime peer dependency removal that requires adjustment, I can approve once that change is undone.

Hopefully we can get rid of some of these peer dependencies from our dependencies soon, they seem largely unhelpful

[mcmire]

@Gudahtt Just pushed up a commit: 52a8357. Do the changes there make sense? If so I can apply them to the other controllers.

[Gudahtt]

Looks reasonable to me!

[mcmire]

Not added to peerDependencies because @metamask/ethjs-provider-http, which requires it, is in devDependencies.

[mcmire]

I have copied the ranges for these peer dependencies from the packages that require them instead of using new ranges.

[Gudahtt]

LGTM!