Skip to content

Fix peer dependency warnings #4974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Fix peer dependency warnings #4974

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e275e3b
Fix peer dependency warnings
mcmire Nov 25, 2024
8a25551
Merge branch 'main' into fix-peer-dep-warnings
mcmire Nov 25, 2024
0b2746f
Merge branch 'main' into fix-peer-dep-warnings
mcmire Nov 25, 2024
52a8357
Try adding providers and webextension-polyfill as peer deps
mcmire Nov 26, 2024
1982205
Adjust manifests and changelogs again
mcmire Nov 26, 2024
228e0ae
Merge branch 'main' into fix-peer-dep-warnings
mcmire Nov 26, 2024
5803ff4
Adjust more manifests/changelogs
mcmire Nov 26, 2024
f7ea83a
Fix changelog
mcmire Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"@babel/plugin-transform-modules-commonjs": "^7.23.3",
"@babel/preset-typescript": "^7.23.3",
"@lavamoat/allow-scripts": "^3.0.4",
"@lavamoat/preinstall-always-fail": "^2.1.0",
"@metamask/create-release-branch": "^3.1.0",
"@metamask/eslint-config": "^12.2.0",
"@metamask/eslint-config-jest": "^12.1.0",
Expand Down
4 changes: 3 additions & 1 deletion packages/accounts-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,16 @@
"devDependencies": {
"@metamask/auto-changelog": "^3.4.4",
"@metamask/keyring-controller": "^19.0.0",
"@metamask/providers": "^18.1.1",
"@metamask/snaps-controllers": "^9.10.0",
"@types/jest": "^27.4.1",
"@types/readable-stream": "^2.3.0",
"jest": "^27.5.1",
"ts-jest": "^27.1.4",
"typedoc": "^0.24.8",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "~5.2.2"
"typescript": "~5.2.2",
"webextension-polyfill": "^0.12.0"
},
"peerDependencies": {
"@metamask/keyring-controller": "^19.0.0",
Expand Down
5 changes: 4 additions & 1 deletion packages/assets-controllers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"uuid": "^8.3.2"
},
"devDependencies": {
"@babel/runtime": "^7.23.9",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not added to peerDependencies because @metamask/ethjs-provider-http, which requires it, is in devDependencies.

"@metamask/accounts-controller": "^20.0.0",
"@metamask/approval-controller": "^7.1.1",
"@metamask/auto-changelog": "^3.4.4",
Expand All @@ -82,6 +83,7 @@
"@metamask/keyring-controller": "^19.0.0",
"@metamask/network-controller": "^22.0.2",
"@metamask/preferences-controller": "^15.0.0",
"@metamask/providers": "^18.1.1",
"@types/jest": "^27.4.1",
"@types/lodash": "^4.14.191",
"@types/node": "^16.18.54",
Expand All @@ -93,7 +95,8 @@
"ts-jest": "^27.1.4",
"typedoc": "^0.24.8",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "~5.2.2"
"typescript": "~5.2.2",
"webextension-polyfill": "^0.12.0"
},
"peerDependencies": {
"@metamask/accounts-controller": "^20.0.0",
Expand Down
4 changes: 3 additions & 1 deletion packages/chain-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,16 @@
},
"devDependencies": {
"@metamask/auto-changelog": "^3.4.4",
"@metamask/providers": "^18.1.1",
"@types/jest": "^27.4.1",
"@types/readable-stream": "^2.3.0",
"deepmerge": "^4.2.2",
"jest": "^27.5.1",
"ts-jest": "^27.1.4",
"typedoc": "^0.24.8",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "~5.2.2"
"typescript": "~5.2.2",
"webextension-polyfill": "^0.12.0"
},
"engines": {
"node": "^18.18 || >=20"
Expand Down
1 change: 1 addition & 0 deletions packages/controller-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
"fast-deep-equal": "^3.1.3"
},
"devDependencies": {
"@babel/runtime": "^7.23.9",
"@metamask/auto-changelog": "^3.4.4",
"@types/jest": "^27.4.1",
"deepmerge": "^4.2.2",
Expand Down
1 change: 1 addition & 0 deletions packages/gas-fee-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
"uuid": "^8.3.2"
},
"devDependencies": {
"@babel/runtime": "^7.23.9",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/network-controller": "^22.0.2",
"@types/jest": "^27.4.1",
Expand Down
1 change: 1 addition & 0 deletions packages/json-rpc-engine/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
},
"devDependencies": {
"@lavamoat/allow-scripts": "^3.0.4",
"@lavamoat/preinstall-always-fail": "^2.1.0",
"@metamask/auto-changelog": "^3.4.4",
"@types/jest": "^27.4.1",
"deepmerge": "^4.2.2",
Expand Down
5 changes: 4 additions & 1 deletion packages/keyring-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@
"@ethereumjs/tx": "^4.2.0",
"@keystonehq/bc-ur-registry-eth": "^0.19.0",
"@lavamoat/allow-scripts": "^3.0.4",
"@lavamoat/preinstall-always-fail": "^2.1.0",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/providers": "^18.1.1",
"@metamask/scure-bip39": "^2.1.1",
"@types/jest": "^27.4.1",
"deepmerge": "^4.2.2",
Expand All @@ -77,7 +79,8 @@
"typedoc": "^0.24.8",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "~5.2.2",
"uuid": "^8.3.2"
"uuid": "^8.3.2",
"webextension-polyfill": "^0.12.0"
},
"engines": {
"node": "^18.18 || >=20"
Expand Down
1 change: 1 addition & 0 deletions packages/notification-services-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@
},
"devDependencies": {
"@lavamoat/allow-scripts": "^3.0.4",
"@lavamoat/preinstall-always-fail": "^2.1.0",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/keyring-controller": "^19.0.0",
"@metamask/profile-sync-controller": "^2.0.0",
Expand Down
5 changes: 4 additions & 1 deletion packages/profile-sync-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,10 @@
},
"devDependencies": {
"@lavamoat/allow-scripts": "^3.0.4",
"@lavamoat/preinstall-always-fail": "^2.1.0",
"@metamask/accounts-controller": "^20.0.0",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/providers": "^18.1.1",
"@metamask/snaps-controllers": "^9.10.0",
"@types/jest": "^27.4.1",
"deepmerge": "^4.2.2",
Expand All @@ -126,7 +128,8 @@
"ts-jest": "^27.1.4",
"typedoc": "^0.24.8",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "~5.2.2"
"typescript": "~5.2.2",
"webextension-polyfill": "^0.12.0"
},
"peerDependencies": {
"@metamask/accounts-controller": "^20.0.0",
Expand Down
5 changes: 5 additions & 0 deletions packages/transaction-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Remove peer dependency `@babel/runtime@^7.23.9`
- This was presumably added because it is a peer dependency of `eth-method-registry`, but it only needs to be added as a dev dependency.

## [40.1.0]

### Added
Expand Down
3 changes: 1 addition & 2 deletions packages/transaction-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@
"uuid": "^8.3.2"
},
"devDependencies": {
"@babel/runtime": "^7.23.9",
"@metamask/accounts-controller": "^20.0.0",
"@metamask/approval-controller": "^7.1.1",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/eth-block-tracker": "^11.0.2",
"@metamask/eth-json-rpc-provider": "^4.1.6",
"@metamask/ethjs-provider-http": "^0.3.0",
"@metamask/gas-fee-controller": "^22.0.1",
Expand All @@ -90,7 +90,6 @@
"typescript": "~5.2.2"
},
"peerDependencies": {
"@babel/runtime": "^7.23.9",
"@metamask/accounts-controller": "^20.0.0",
"@metamask/approval-controller": "^7.0.0",
"@metamask/gas-fee-controller": "^22.0.0",
Expand Down
28 changes: 26 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2017,6 +2017,13 @@ __metadata:
languageName: node
linkType: hard

"@lavamoat/preinstall-always-fail@npm:^2.1.0":
version: 2.1.0
resolution: "@lavamoat/preinstall-always-fail@npm:2.1.0"
checksum: 10/385c3fac828b9edff2d8b5825bd29ea475206046984cdb3217518ad655f145ff37046414041534960d92cbe0759f0dc675f7c7dcf39a95003ae715a834fbd750
languageName: node
linkType: hard

"@metamask/abi-utils@npm:^2.0.3, @metamask/abi-utils@npm:^2.0.4":
version: 2.0.4
resolution: "@metamask/abi-utils@npm:2.0.4"
Expand All @@ -2037,6 +2044,7 @@ __metadata:
"@metamask/eth-snap-keyring": "npm:^5.0.1"
"@metamask/keyring-api": "npm:^10.1.0"
"@metamask/keyring-controller": "npm:^19.0.0"
"@metamask/providers": "npm:^18.1.1"
"@metamask/snaps-controllers": "npm:^9.10.0"
"@metamask/snaps-sdk": "npm:^6.7.0"
"@metamask/snaps-utils": "npm:^8.3.0"
Expand All @@ -2052,6 +2060,7 @@ __metadata:
typedoc-plugin-missing-exports: "npm:^2.0.0"
typescript: "npm:~5.2.2"
uuid: "npm:^8.3.2"
webextension-polyfill: "npm:^0.12.0"
peerDependencies:
"@metamask/keyring-controller": ^19.0.0
"@metamask/snaps-controllers": ^9.7.0
Expand Down Expand Up @@ -2134,6 +2143,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@metamask/assets-controllers@workspace:packages/assets-controllers"
dependencies:
"@babel/runtime": "npm:^7.23.9"
"@ethereumjs/util": "npm:^8.1.0"
"@ethersproject/abi": "npm:^5.7.0"
"@ethersproject/address": "npm:^5.7.0"
Expand All @@ -2155,6 +2165,7 @@ __metadata:
"@metamask/network-controller": "npm:^22.0.2"
"@metamask/polling-controller": "npm:^12.0.1"
"@metamask/preferences-controller": "npm:^15.0.0"
"@metamask/providers": "npm:^18.1.1"
"@metamask/rpc-errors": "npm:^7.0.1"
"@metamask/utils": "npm:^10.0.0"
"@types/bn.js": "npm:^5.1.5"
Expand All @@ -2179,6 +2190,7 @@ __metadata:
typedoc-plugin-missing-exports: "npm:^2.0.0"
typescript: "npm:~5.2.2"
uuid: "npm:^8.3.2"
webextension-polyfill: "npm:^0.12.0"
peerDependencies:
"@metamask/accounts-controller": ^20.0.0
"@metamask/approval-controller": ^7.0.0
Expand Down Expand Up @@ -2283,6 +2295,7 @@ __metadata:
"@metamask/base-controller": "npm:^7.0.2"
"@metamask/chain-api": "npm:^0.1.0"
"@metamask/keyring-api": "npm:^10.1.0"
"@metamask/providers": "npm:^18.1.1"
"@metamask/snaps-controllers": "npm:^9.10.0"
"@metamask/snaps-sdk": "npm:^6.7.0"
"@metamask/snaps-utils": "npm:^8.3.0"
Expand All @@ -2296,6 +2309,7 @@ __metadata:
typedoc-plugin-missing-exports: "npm:^2.0.0"
typescript: "npm:~5.2.2"
uuid: "npm:^8.3.2"
webextension-polyfill: "npm:^0.12.0"
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -2329,6 +2343,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@metamask/controller-utils@workspace:packages/controller-utils"
dependencies:
"@babel/runtime": "npm:^7.23.9"
"@ethereumjs/util": "npm:^8.1.0"
"@metamask/auto-changelog": "npm:^3.4.4"
"@metamask/eth-query": "npm:^4.0.0"
Expand Down Expand Up @@ -2359,6 +2374,7 @@ __metadata:
"@babel/plugin-transform-modules-commonjs": "npm:^7.23.3"
"@babel/preset-typescript": "npm:^7.23.3"
"@lavamoat/allow-scripts": "npm:^3.0.4"
"@lavamoat/preinstall-always-fail": "npm:^2.1.0"
"@metamask/create-release-branch": "npm:^3.1.0"
"@metamask/eslint-config": "npm:^12.2.0"
"@metamask/eslint-config-jest": "npm:^12.1.0"
Expand Down Expand Up @@ -2832,6 +2848,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@metamask/gas-fee-controller@workspace:packages/gas-fee-controller"
dependencies:
"@babel/runtime": "npm:^7.23.9"
"@metamask/auto-changelog": "npm:^3.4.4"
"@metamask/base-controller": "npm:^7.0.2"
"@metamask/controller-utils": "npm:^11.4.3"
Expand Down Expand Up @@ -2865,6 +2882,7 @@ __metadata:
resolution: "@metamask/json-rpc-engine@workspace:packages/json-rpc-engine"
dependencies:
"@lavamoat/allow-scripts": "npm:^3.0.4"
"@lavamoat/preinstall-always-fail": "npm:^2.1.0"
"@metamask/auto-changelog": "npm:^3.4.4"
"@metamask/rpc-errors": "npm:^7.0.1"
"@metamask/safe-event-emitter": "npm:^3.0.0"
Expand Down Expand Up @@ -2953,6 +2971,7 @@ __metadata:
"@keystonehq/bc-ur-registry-eth": "npm:^0.19.0"
"@keystonehq/metamask-airgapped-keyring": "npm:^0.14.1"
"@lavamoat/allow-scripts": "npm:^3.0.4"
"@lavamoat/preinstall-always-fail": "npm:^2.1.0"
"@metamask/auto-changelog": "npm:^3.4.4"
"@metamask/base-controller": "npm:^7.0.2"
"@metamask/browser-passworder": "npm:^4.3.0"
Expand All @@ -2961,6 +2980,7 @@ __metadata:
"@metamask/eth-simple-keyring": "npm:^6.0.5"
"@metamask/keyring-api": "npm:^10.1.0"
"@metamask/message-manager": "npm:^11.0.1"
"@metamask/providers": "npm:^18.1.1"
"@metamask/scure-bip39": "npm:^2.1.1"
"@metamask/utils": "npm:^10.0.0"
"@types/jest": "npm:^27.4.1"
Expand All @@ -2976,6 +2996,7 @@ __metadata:
typedoc-plugin-missing-exports: "npm:^2.0.0"
typescript: "npm:~5.2.2"
uuid: "npm:^8.3.2"
webextension-polyfill: "npm:^0.12.0"
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -3146,6 +3167,7 @@ __metadata:
dependencies:
"@contentful/rich-text-html-renderer": "npm:^16.5.2"
"@lavamoat/allow-scripts": "npm:^3.0.4"
"@lavamoat/preinstall-always-fail": "npm:^2.1.0"
"@metamask/auto-changelog": "npm:^3.4.4"
"@metamask/base-controller": "npm:^7.0.2"
"@metamask/controller-utils": "npm:^11.4.3"
Expand Down Expand Up @@ -3336,12 +3358,14 @@ __metadata:
resolution: "@metamask/profile-sync-controller@workspace:packages/profile-sync-controller"
dependencies:
"@lavamoat/allow-scripts": "npm:^3.0.4"
"@lavamoat/preinstall-always-fail": "npm:^2.1.0"
"@metamask/accounts-controller": "npm:^20.0.0"
"@metamask/auto-changelog": "npm:^3.4.4"
"@metamask/base-controller": "npm:^7.0.2"
"@metamask/keyring-api": "npm:^10.1.0"
"@metamask/keyring-controller": "npm:^19.0.0"
"@metamask/network-controller": "npm:^22.0.2"
"@metamask/providers": "npm:^18.1.1"
"@metamask/snaps-controllers": "npm:^9.10.0"
"@metamask/snaps-sdk": "npm:^6.7.0"
"@metamask/snaps-utils": "npm:^8.3.0"
Expand All @@ -3360,6 +3384,7 @@ __metadata:
typedoc: "npm:^0.24.8"
typedoc-plugin-missing-exports: "npm:^2.0.0"
typescript: "npm:~5.2.2"
webextension-polyfill: "npm:^0.12.0"
peerDependencies:
"@metamask/accounts-controller": ^20.0.0
"@metamask/keyring-controller": ^19.0.0
Expand Down Expand Up @@ -3668,7 +3693,6 @@ __metadata:
version: 0.0.0-use.local
resolution: "@metamask/transaction-controller@workspace:packages/transaction-controller"
dependencies:
"@babel/runtime": "npm:^7.23.9"
"@ethereumjs/common": "npm:^3.2.0"
"@ethereumjs/tx": "npm:^4.2.0"
"@ethereumjs/util": "npm:^8.1.0"
Expand All @@ -3680,6 +3704,7 @@ __metadata:
"@metamask/auto-changelog": "npm:^3.4.4"
"@metamask/base-controller": "npm:^7.0.2"
"@metamask/controller-utils": "npm:^11.4.3"
"@metamask/eth-block-tracker": "npm:^11.0.2"
"@metamask/eth-json-rpc-provider": "npm:^4.1.6"
"@metamask/eth-query": "npm:^4.0.0"
"@metamask/ethjs-provider-http": "npm:^0.3.0"
Expand Down Expand Up @@ -3708,7 +3733,6 @@ __metadata:
typescript: "npm:~5.2.2"
uuid: "npm:^8.3.2"
peerDependencies:
"@babel/runtime": ^7.23.9
"@metamask/accounts-controller": ^20.0.0
"@metamask/approval-controller": ^7.0.0
"@metamask/gas-fee-controller": ^22.0.0
Expand Down
Loading