API-125 - Migrated from metaswap to metafi subdomain for proxy and token icons #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! I checked this out locally and found 3 more references to "metaswap.codefi.network":
Have the |
|
api.metaswap.codefi.network was decommissioned. token-api is still located at token-api.metaswap.codefi.network. |
|
Makes sense! Looks like there is now a conflict, but I can approve once that has been resolved |
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…ken icons (#1060) **PR Title** - Migrates from *.metaswap.codefi.network to *.metafi.codefi.network for `proxy` and `static` subdomains. MetaMask Platform API team is migrating from metaswap aws accounts to their own. **Description** _Itemize the changes you have made into the categories below_ - BREAKING: - Uses new subdomains for providing the opensea proxy and token icons cache. - CHANGED: - Uses new subdomains for providing the opensea proxy and token icons cache. - New infrastructure enables a new mechanism to handle support requests for changes to token icons. Now https://github.com/MetaMask/contract-metadata will be the priority provider of icons, such that changes there will overwrite any existing token icons we're fetching and caching from other providers.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…ken icons (#1060) **PR Title** - Migrates from *.metaswap.codefi.network to *.metafi.codefi.network for `proxy` and `static` subdomains. MetaMask Platform API team is migrating from metaswap aws accounts to their own. **Description** _Itemize the changes you have made into the categories below_ - BREAKING: - Uses new subdomains for providing the opensea proxy and token icons cache. - CHANGED: - Uses new subdomains for providing the opensea proxy and token icons cache. - New infrastructure enables a new mechanism to handle support requests for changes to token icons. Now https://github.com/MetaMask/contract-metadata will be the priority provider of icons, such that changes there will overwrite any existing token icons we're fetching and caching from other providers.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
proxyandstaticsubdomains. MetaMask Platform API team is migrating from metaswap aws accounts to their own.Description
Itemize the changes you have made into the categories below
BREAKING:
CHANGED: