fix(controller-utils): Fix query function #1447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, a few more type errors to fix. Working on that now. |
mcmire
reviewed
Jun 23, 2023
The `query` function was updated in #1266 to use `hasProperty` has part of an effect to improve the types being used. Unfortunately this had the unexpected affected of breaking this condition because `hasProperty` doesn't look up the prototype chain, but the method we were checking for was on the prototype. `hasProperty` is only meant to be used with plain objects. The condition has been updated to use `in`, and the tests have been updated to use a more realistic EthQuery mock that has methods as prototypes. To fix various type errors, an old inlined EthQueryLike type has been replaced by the real EthQuery type. This required adding `eth-query` as a dependency to the controller utils package.
Gudahtt
force-pushed
the
fix-query-function
branch
from
a2a465b to
a9896ab
Compare
danjm
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
LGTM! In addition to code review, I did some manual QA with reference to MetaMask/metamask-extension#19735
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `query` function was updated in #1266 to use `hasProperty` has part of an effect to improve the types being used. Unfortunately this had the unexpected affected of breaking this condition because `hasProperty` doesn't look up the prototype chain, but the method we were checking for was on the prototype. `hasProperty` is only meant to be used with plain objects. The condition has been updated to use `in`, and the tests have been updated to use a more realistic EthQuery mock that has methods as prototypes. To fix various type errors, an old inlined EthQueryLike type has been replaced by the real EthQuery type. This required adding `eth-query` as a dependency to the controller utils package.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `query` function was updated in #1266 to use `hasProperty` has part of an effect to improve the types being used. Unfortunately this had the unexpected affected of breaking this condition because `hasProperty` doesn't look up the prototype chain, but the method we were checking for was on the prototype. `hasProperty` is only meant to be used with plain objects. The condition has been updated to use `in`, and the tests have been updated to use a more realistic EthQuery mock that has methods as prototypes. To fix various type errors, an old inlined EthQueryLike type has been replaced by the real EthQuery type. This required adding `eth-query` as a dependency to the controller utils package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
queryfunction was updated in #1266 to usehasPropertyhas part of an effect to improve the types being used. Unfortunately this had the unexpected affected of breaking this condition becausehasPropertydoesn't look up the prototype chain, but the method we were checking for was on the prototype.hasPropertyis only meant to be used with plain objects.The condition has been updated to use
in, and the tests have been updated to use a more realistic EthQuery mock that has methods as prototypes.To fix various type errors, an old inlined EthQueryLike type has been replaced by the real EthQuery type. This required adding
eth-queryas a dependency to the controller utils package.References
Related to MetaMask/metamask-extension#19735
Changelog
@metamask/controller-utilsqueryfunction failed to call built-in EthQuery methodseth-queryandbabel-runtimeChecklist