Skip to content

fix(22139): add header to requests going to CoinGecko #3619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DDDDDanica
Copy link
Contributor

Explanation

Add a header to CoinGecko related requests to help with api abuse and give a buffer time for replacing with our own pricing api.

References

Changelog

@metamask/assets-controllers

  • ADDED: Add header to requests against CoinGecko

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@DDDDDanica DDDDDanica self-assigned this Dec 5, 2023
@DDDDDanica DDDDDanica requested a review from a team as a code owner December 5, 2023 18:42
adonesky1 added a commit to MetaMask/metamask-extension that referenced this pull request Dec 6, 2023
Bumps `@metamask/assets-controller` to v20.0.0.

Adds `getNetworkClientById` callback to `TokenRatesController`
constructor to [address only breaking
change](https://github.com/MetaMask/core/blob/9238108438e61dcae39ec8a02d1a15aa540da4c4/packages/assets-controllers/CHANGELOG.md?plain=1#L14)

This overwrites and deletes a patch that was added on top of
`@metamask/assets-controllers` version 19.0.0. This was added for the
11.7.0 extension release but can be removed now and will be added back
later via MetaMask/core#3619 (cc @DDDDDanica
@Gudahtt)
@mcmire
Copy link
Contributor

mcmire commented Dec 7, 2023

Hi @DDDDDanica! We've completely removed the CoinGecko code from this controller here: #3600

@DDDDDanica DDDDDanica closed this Dec 12, 2023
danjm pushed a commit to MetaMask/metamask-extension that referenced this pull request Dec 20, 2023
Bumps `@metamask/assets-controller` to v20.0.0.

Adds `getNetworkClientById` callback to `TokenRatesController`
constructor to [address only breaking
change](https://github.com/MetaMask/core/blob/9238108438e61dcae39ec8a02d1a15aa540da4c4/packages/assets-controllers/CHANGELOG.md?plain=1#L14)

This overwrites and deletes a patch that was added on top of
`@metamask/assets-controllers` version 19.0.0. This was added for the
11.7.0 extension release but can be removed now and will be added back
later via MetaMask/core#3619 (cc @DDDDDanica
@Gudahtt)
danjm pushed a commit to MetaMask/metamask-extension that referenced this pull request Dec 22, 2023
Bumps `@metamask/assets-controller` to v20.0.0.

Adds `getNetworkClientById` callback to `TokenRatesController`
constructor to [address only breaking
change](https://github.com/MetaMask/core/blob/9238108438e61dcae39ec8a02d1a15aa540da4c4/packages/assets-controllers/CHANGELOG.md?plain=1#L14)

This overwrites and deletes a patch that was added on top of
`@metamask/assets-controllers` version 19.0.0. This was added for the
11.7.0 extension release but can be removed now and will be added back
later via MetaMask/core#3619 (cc @DDDDDanica
@Gudahtt)
@DDDDDanica DDDDDanica deleted the fix/22139-CoinGecko branch March 21, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants