Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(runway): cherry-pick fix: cp-12.14.0 bridge status validation causes transactions to be pending indefinitely #30953

Open
wants to merge 2 commits into
base: Version-v12.14.0
Choose a base branch
from

Conversation

runway-github[bot]
Copy link

@runway-github runway-github bot commented Mar 12, 2025

Description

Depends on bridge-api update:
https://github.com/consensys-vertical-apps/va-mmcx-bridge-api/pull/182

Addresses these issues

  • getTxStatus reponses get rejected due to EVM-specific validation
  • Activity details for bridging from EVM > Solana has missing network
    info

Open in GitHub Codespaces

Related issues

Fixes: #30885 ,
#30801

Manual testing steps

  1. Bridge EVM <> EVM
  2. Bridge EVM <> Solana
  3. Bridge Solana <> EVM
  4. After 5 mins, verify that there are no failing getTxStatus calls in
    the background
  5. Verify that polling for these new transactions stop eventually

Screenshots/Recordings

Before

Screenshot 2025-03-11 at 7 14 05 PM
Screenshot 2025-03-11 at 7 14 13 PM

After

Screenshot 2025-03-11 at 7 09 47 PM
Screenshot 2025-03-11 at 7 09 55 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. e144891

…auses transactions to be pending indefinitely (#30918)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Depends on bridge-api update:
consensys-vertical-apps/va-mmcx-bridge-api#182

Addresses these issues
- getTxStatus reponses get rejected due to EVM-specific validation
- Activity details for bridging from EVM > Solana has missing network
info

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30918?quickstart=1)

## **Related issues**

Fixes: #30885 ,
#30801

## **Manual testing steps**

1. Bridge EVM <> EVM
2. Bridge EVM <> Solana
3. Bridge Solana <> EVM
4. After 5 mins, verify that there are no failing getTxStatus calls in
the background
5. Verify that polling for these new transactions stop eventually

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->
![Screenshot 2025-03-11 at 7 14
05 PM](https://github.com/user-attachments/assets/ff080c6a-8791-4194-bf2b-e3224e7bb745)
![Screenshot 2025-03-11 at 7 14
13 PM](https://github.com/user-attachments/assets/b3c74449-55f4-4ef5-a6a1-82162a7561ac)

### **After**

<!-- [screenshots/recordings] -->
![Screenshot 2025-03-11 at 7 09
47 PM](https://github.com/user-attachments/assets/b2688e28-bc2c-453f-b721-7ba326989d0c)
![Screenshot 2025-03-11 at 7 09
55 PM](https://github.com/user-attachments/assets/12c28cec-00df-4141-9c4d-82e598464e7f)


## **Pre-merge author checklist**


- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@runway-github runway-github bot requested a review from a team as a code owner March 12, 2025 23:31
@metamaskbot metamaskbot added the team-runway-bot Runway bot team (for Runway Bot) label Mar 12, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [2246c28]
Page Load Metrics (1879 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint35221001693444213
domContentLoaded157525021837212102
load159525131879210101
domInteractive2793502110
backgroundConnect15132473014
firstReactRender1575332110
getState676222010
initialActions01000
loadScripts11601908137217182
setupStore86019178
uiStartup179828792147257123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-runway-bot Runway bot team (for Runway Bot)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants