Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable minification #1709 #1710

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

jclaveau
Copy link
Contributor

@jclaveau jclaveau commented Mar 4, 2025

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Disable the minification in builds to ease the developers experience as proposed here #1709

How did you test this change?

cd milkdown
rm -rf .nx
pn build
cd packages/core/lib
cat index.es.js
# Should not be minified anymore

Also disabling Terser options is recommended here vitejs/vite#14320 (comment)

Please tell me if you'd like a minification step to apply afterwards (or feel free to close it if you disagree with this proposal, obviously :) )

Copy link

changeset-bot bot commented Mar 4, 2025

⚠️ No Changeset found

Latest commit: ceb310c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 5:03pm

Copy link

nx-cloud bot commented Mar 6, 2025

View your CI Pipeline Execution ↗ for commit ceb310c.

Command Status Duration Result
nx run-many --target=build --all --parallel ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-06 05:36:15 UTC

@Saul-Mirone
Copy link
Member

Thanks for your contribution. I think this does make some sense. I'll merge the pr.

@Saul-Mirone Saul-Mirone added this pull request to the merge queue Mar 6, 2025
Merged via the queue into Milkdown:main with commit b3f569c Mar 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants