Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/custom uni UI lint #1400

Merged
merged 17 commits into from
Mar 25, 2025
Merged

Enhancement/custom uni UI lint #1400

merged 17 commits into from
Mar 25, 2025

Conversation

Pinho13
Copy link
Contributor

@Pinho13 Pinho13 commented Nov 26, 2024

closes #1385

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12%. Comparing base (155dda9) to head (1a8024e).
Report is 19 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff           @@
##           develop   #1400   +/-   ##
=======================================
  Coverage       12%     12%           
=======================================
  Files          265     265           
  Lines         7397    7397           
=======================================
  Hits           819     819           
  Misses        6578    6578
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pinho13 @limwa
Starter Setup
Loading
Loading status checks…
1f9da2d
@Pinho13 @limwa
enhancement: Started working on String Literal in Widget lint custom …

Verified

This commit was signed with the committer’s verified signature.
UlisesGascon Ulises Gascón
GPG key ID: 04CD3F2FDE079578
Verified
Learn about vigilant mode
ae06cd2 
…rule
@Pinho13 @limwa
Minor Changes
001a5c3
@Pinho13 @limwa
analysis_options.yaml updated

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600
Verified
Learn about vigilant mode
9142c2d
@limwa limwa force-pushed the enhancement/Custom_Uni_UI_Lint branch from c8e76b4 to 9142c2d Compare December 9, 2024 16:35
@limwa limwa mentioned this pull request Dec 9, 2024
Merged
7 tasks
@Pinho13 Pinho13 requested review from thePeras and DGoiana December 27, 2024 15:21
@thePeras thePeras requested a review from limwa December 27, 2024 16:23
limwa
limwa requested changes Dec 27, 2024
View reviewed changes
Copy link
Member

@limwa limwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress so far, but some things are still needed before we can merge this PR

@Pinho13
Copy link
Contributor Author

Pinho13 commented Jan 1, 2025

@limwa I think everything is solved, please do let me know if anything else is missing!

@Pinho13 Pinho13 requested a review from limwa January 1, 2025 21:53
limwa
limwa requested changes Jan 1, 2025
View reviewed changes
thePeras
thePeras approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃

@thePeras
Copy link
Member

@Pinho13 the ball is on you now

@Pinho13 Pinho13 merged commit dd91fd8 into develop Mar 25, 2025
4 checks passed
@Pinho13 Pinho13 deleted the enhancement/Custom_Uni_UI_Lint branch March 25, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limwa limwa

@thePeras thePeras

@DGoiana DGoiana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create uni_ui custom lint rule to avoid string literals
4 participants
@Pinho13 @thePeras @limwa @DGoiana