Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/empty state illustrations #1415

Closed
wants to merge 5 commits into from

Conversation

GuiCNunes
Copy link

@GuiCNunes GuiCNunes commented Dec 17, 2024

Closes #639
Empty state ilustrations for schedule and exams cards.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Sorry, something went wrong.

@GuiCNunes GuiCNunes requested a review from a team December 17, 2024 18:05

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12%. Comparing base (92e33f6) to head (ad891f9).
Report is 758 commits behind head on ui/redesign.

Additional details and impacted files
@@             Coverage Diff             @@
##           ui/redesign   #1415   +/-   ##
===========================================
+ Coverage           12%     12%   +1%     
===========================================
  Files              265     265           
  Lines             7209    7203    -6     
===========================================
+ Hits               806     808    +2     
+ Misses            6403    6395    -8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is almost perfect.
Leave us some screenshots to see the results, please

onNullContent: const Center(
child: ImageLabel(
imagePath: 'assets/images/papers.png',
label: 'Não há exames',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use translations

onNullContent: const Center(
child: ImageLabel(
imagePath: 'assets/images/no_data.png',
label: 'Não há aulas',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use translations

@thePeras
Copy link
Member

@DGoiana I think this is now unused with the lasted home cards.

@DGoiana DGoiana closed this Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants