Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schedule page double refresh indicator #1512

Merged
merged 5 commits into from
Mar 19, 2025

Conversation

peucastro
Copy link
Member

@peucastro peucastro commented Mar 7, 2025

Closes #1497
Removes the double refresh indicator at the schedule page.

Screenshot

screen-20250307-095328.mp4

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (0c10fd6) to head (8e17789).
Report is 7 commits behind head on ui/redesign.

Additional details and impacted files
@@             Coverage Diff             @@
##           ui/redesign   #1512   +/-   ##
===========================================
+ Coverage           11%     11%   +1%     
===========================================
  Files              263     263           
  Lines             7715    7712    -3     
===========================================
  Hits               825     825           
+ Misses            6890    6887    -3     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peucastro
Copy link
Member Author

I'm still not able to replicate the behavior of the courses page (where a center refresh indicator appears replacing then NoClassesWidget). Probably going to need some help with that.

@DGoiana
Copy link
Collaborator

DGoiana commented Mar 12, 2025

I'm still not able to replicate the behavior of the courses page (where a center refresh indicator appears replacing then NoClassesWidget). Probably going to need some help with that.

I think I prefer the way you did here. Can you implement this behavior on the courses page, and others?

@peucastro peucastro marked this pull request as ready for review March 12, 2025 17:40
Copy link
Contributor

@Granja5 Granja5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazinga

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 🛫

@peucastro peucastro merged commit ad89e6c into ui/redesign Mar 19, 2025
6 checks passed
@peucastro peucastro deleted the fix/schedulePageDoubleRefreshIndicator branch March 19, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants