Jd/move structs to is #1068
Merged
Jd/move structs to is #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add place holders * add requires_reconciliation trait * afc/created test for ic * afc/added functions on PSI for ic reconciliation * afc/fixed rounding, tested Still getting the same error as before on T=7 * add place holders * add requires_reconciliation trait * afc/created test for ic * afc/added functions on PSI for ic reconciliation * afc/fixed rounding, tested Still getting the same error as before on T=7 * add place holders * add requires_reconciliation trait * afc/created test for ic * afc/added functions on PSI for ic reconciliation * afc/fixed rounding, tested Still getting the same error as before on T=7 * add place holders * afc/created test for ic * afc/added functions on PSI for ic reconciliation * afc/fixed rounding, tested Still getting the same error as before on T=7 * formatter --------- Co-authored-by: alefcastelli <alef.castelli@gmail.com>
Co-authored-by: lpstreitmatter <61252469+lpstreitmatter@users.noreply.github.com>
…PowerSimulations.jl into jd/move_structs_to_is
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…PowerSimulations.jl into jd/move_structs_to_is
src/core/definitions.jl
Outdated
| @@ -123,21 +118,7 @@ function get_enum_value(enum, value::String) | |||
| return ENUM_MAPPINGS[enum][val] | |||
| end | |||
|
|
|||
| Base.convert(::Type{BuildStatus}, val::String) = get_enum_value(BuildStatus, val) | |||
| Base.convert(::Type{SimulationBuildStatus}, val::String) = get_enum_value(SimulationBuildStatus, val) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| Base.convert(::Type{SimulationBuildStatus}, val::String) = get_enum_value(SimulationBuildStatus, val) | |
| Base.convert(::Type{SimulationBuildStatus}, val::String) = | |
| get_enum_value(SimulationBuildStatus, val) |
src/simulation/simulation.jl
Outdated
| error("Simulation status is invalid, you need to rebuild the simulation") | ||
| sim_status = get_simulation_build_status(sim) | ||
| if (sim_status != SimulationBuildStatus.BUILT) || (sim_status != RunStatus.READY) | ||
| error("Simulation status $sim_status is invalid, you need to rebuild the simulation") |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| error("Simulation status $sim_status is invalid, you need to rebuild the simulation") | |
| error( | |
| "Simulation status $sim_status is invalid, you need to rebuild the simulation", | |
| ) |
| @@ -27,7 +27,7 @@ end | |||
| limits = PSY.get_flow_limits(PSY.get_component(MonitoredLine, system, "1")) | |||
| template = get_thermal_dispatch_template_network(ACPPowerModel) | |||
| model_m = DecisionModel(template, system; optimizer = ipopt_optimizer) | |||
| @test build!(model_m; output_dir = mktempdir(; cleanup = true)) == PSI.BuildStatus.BUILT | |||
| @test build!(model_m; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test build!(model_m; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |
| @test build!(model_m; output_dir = mktempdir(; cleanup = true)) == | |
| PSI.ModelBuildStatus.BUILT |
| set_device_model!(template, DeviceModel(TwoTerminalHVDCLine, HVDCTwoTerminalLossless)) | ||
| model_m = DecisionModel(template, system; optimizer = HiGHS_optimizer) | ||
| @test build!(model_m; output_dir = mktempdir(; cleanup = true)) == PSI.BuildStatus.BUILT | ||
| @test build!(model_m; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test build!(model_m; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |
| @test build!(model_m; output_dir = mktempdir(; cleanup = true)) == | |
| PSI.ModelBuildStatus.BUILT |
| @@ -559,7 +571,7 @@ end | |||
| ) | |||
| set_device_model!(template, DeviceModel(PhaseShiftingTransformer, PhaseAngleControl)) | |||
| model_m = DecisionModel(template, system; optimizer = HiGHS_optimizer) | |||
| @test build!(model_m; output_dir = mktempdir(; cleanup = true)) == PSI.BuildStatus.BUILT | |||
| @test build!(model_m; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test build!(model_m; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |
| @test build!(model_m; output_dir = mktempdir(; cleanup = true)) == | |
| PSI.ModelBuildStatus.BUILT |
test/test_services_constructor.jl
Outdated
| @@ -57,15 +57,15 @@ end | |||
|
|
|||
| c_sys5_uc = PSB.build_system(PSITestSystems, "c_sys5_uc"; add_reserves = true) | |||
| model = DecisionModel(template, c_sys5_uc) | |||
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.BuildStatus.BUILT | |||
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == | |
| PSI.ModelBuildStatus.BUILT |
test/test_services_constructor.jl
Outdated
| @@ -95,7 +95,7 @@ end | |||
| c_sys5_uc = PSB.build_system(PSITestSystems, "c_sys5_uc"; add_reserves = true) | |||
|
|
|||
| model = DecisionModel(template, c_sys5_uc; optimizer = cbc_optimizer) | |||
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.BuildStatus.BUILT | |||
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == | |
| PSI.ModelBuildStatus.BUILT |
test/test_services_constructor.jl
Outdated
| @@ -112,7 +112,7 @@ end | |||
|
|
|||
| c_sys5_uc = PSB.build_system(PSITestSystems, "c_sys5_uc_non_spin"; add_reserves = true) | |||
| model = DecisionModel(template, c_sys5_uc; optimizer = HiGHS_optimizer) | |||
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.BuildStatus.BUILT | |||
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == | |
| PSI.ModelBuildStatus.BUILT |
test/test_services_constructor.jl
Outdated
| @@ -131,7 +131,7 @@ end | |||
|
|
|||
| c_sys5_re = PSB.build_system(PSITestSystems, "c_sys5_re"; add_reserves = true) | |||
| model = DecisionModel(template, c_sys5_re) | |||
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.BuildStatus.BUILT | |||
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == | |
| PSI.ModelBuildStatus.BUILT |
test/test_services_constructor.jl
Outdated
| @@ -154,7 +154,7 @@ end | |||
|
|
|||
| c_sys5_hyd = PSB.build_system(PSITestSystems, "c_sys5_hyd"; add_reserves = true) | |||
| model = DecisionModel(template, c_sys5_hyd) | |||
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.BuildStatus.BUILT | |||
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == PSI.ModelBuildStatus.BUILT | |
| @test build!(model; output_dir = mktempdir(; cleanup = true)) == | |
| PSI.ModelBuildStatus.BUILT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to NREL-Sienna/InfrastructureSystems.jl#335