-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update cost functions for thermal dispatch no min #1223
Conversation
@@ -342,6 +342,29 @@ function is_time_variant(cost_function::PSY.FuelCurve{PSY.PiecewisePointCurve}) | |||
return isa(PSY.get_fuel_cost(cost_function), IS.TimeSeriesKey) | |||
end | |||
|
|||
function create_temporary_cost_function_in_system_per_unit( | |||
original_cost_function::PSY.CostCurve, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodrigomha do we need to make this a more specific type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends. The function just replace the data in the value curve with a new value curve, always assuming that the new point data comes in per-unit, so it does not really matter whatever the original data was from (Incremental or Point or Average).
Alternatively, using something like PSY.CostCurve{PSY.PiecewisePointCurve}
and PSY.FuelCurve{PSY.PiecewisePointCurve}
would work for the purposes of this PR, and will only work if the data comes from a PointCurve.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1223 +/- ##
==========================================
- Coverage 77.18% 77.08% -0.10%
==========================================
Files 122 122
Lines 13561 13566 +5
==========================================
- Hits 10467 10458 -9
- Misses 3094 3108 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Performance Results
|
Closes #1221