new debug logging, fix logic #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -290,6 +293,7 @@ function update_decision_state!( | |||
| @error "update $name to come back online after $off_time_step_count" | |||
| end | |||
| end | |||
| @warn "AvailableStatusChangeParameter decision state after update: $state_data" | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @warn "AvailableStatusChangeParameter decision state after update: $state_data" | |
| @warn "AvailableStatusChangeParameter decision state after update: $state_data" |
| @@ -304,7 +308,8 @@ function update_decision_state!( | |||
| ) where {T <: PSY.Component} | |||
| event_ocurrence_data = get_decision_state_data(state, AvailableStatusChangeParameter(), T) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| event_ocurrence_data = get_decision_state_data(state, AvailableStatusChangeParameter(), T) | |
| event_ocurrence_data = | |
| get_decision_state_data(state, AvailableStatusChangeParameter(), T) |
Comment on lines
+335
to
+337
| while true | ||
| state_data.values[name, outage_index] = 0.0 | ||
| if (event_ocurrence_data.values[name, outage_index] == 1.0) || outage_index == length(state_data.values[name, :]) #If another change is detected or you have reached the end of the state |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| while true | |
| state_data.values[name, outage_index] = 0.0 | |
| if (event_ocurrence_data.values[name, outage_index] == 1.0) || outage_index == length(state_data.values[name, :]) #If another change is detected or you have reached the end of the state | |
| while true | |
| state_data.values[name, outage_index] = 0.0 | |
| if (event_ocurrence_data.values[name, outage_index] == 1.0) || | |
| outage_index == length(state_data.values[name, :]) #If another change is detected or you have reached the end of the state |
| state_data.values[name, outage_index] = 0.0 | ||
| if (event_ocurrence_data.values[name, outage_index] == 1.0) || outage_index == length(state_data.values[name, :]) #If another change is detected or you have reached the end of the state | ||
| break | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| end | |
| end |
Comment on lines
354
to
+357
| set_last_recorded_row!(state_data, state_range[end]) | ||
| state_data_index += resolution_ratio | ||
| end | ||
| =# | ||
| end =# | ||
| @warn "AvailableStatusParameter decision state after update: $state_data" |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| set_last_recorded_row!(state_data, state_range[end]) | |
| state_data_index += resolution_ratio | |
| end | |
| =# | |
| end =# | |
| @warn "AvailableStatusParameter decision state after update: $state_data" | |
| end | |
| #= offset = resolution_ratio - 1 | |
| result_time_index = axes(store_data)[2] | |
| set_update_timestamp!(state_data, simulation_time) | |
| for t in result_time_index | |
| state_range = state_data_index:(state_data_index + offset) | |
| for name in column_names, i in state_range | |
| state_data.values[name, i] = store_data[name, t] | |
| end | |
| set_last_recorded_row!(state_data, state_range[end]) | |
| state_data_index += resolution_ratio | |
| end =# | |
| @warn "AvailableStatusParameter decision state after update: $state_data" |
| @@ -525,27 +545,20 @@ function update_system_state!( | |||
| simulation_time::Dates.DateTime, | |||
| rng, | |||
| ) where T <: PSY.Device | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| ) where T <: PSY.Device | |
| ) where {T <: PSY.Device} |
Comment on lines
+551
to
+552
| available_status_change_parameter = get_system_state_data(state, AvailableStatusChangeParameter(), T) | ||
| available_status_change_parameter_values = get_last_recorded_value(available_status_change_parameter) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| available_status_change_parameter = get_system_state_data(state, AvailableStatusChangeParameter(), T) | |
| available_status_change_parameter_values = get_last_recorded_value(available_status_change_parameter) | |
| available_status_change_parameter = | |
| get_system_state_data(state, AvailableStatusChangeParameter(), T) | |
| available_status_change_parameter_values = | |
| get_last_recorded_value(available_status_change_parameter) |
| for name in column_names_ | ||
| current_status = available_status_parameter_values[name] | ||
| current_status_change = available_status_change_parameter_values[name] | ||
| if current_status == 1.0 && current_status_change == 1.0 |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| if current_status == 1.0 && current_status_change == 1.0 | |
| if current_status == 1.0 && current_status_change == 1.0 |
Comment on lines
+559
to
561
| available_status_parameter.values[name, 1] = 0.0 | ||
| end | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| available_status_parameter.values[name, 1] = 0.0 | |
| end | |
| end | |
| available_status_parameter.values[name, 1] = 0.0 | |
| end | |
| end |
| @error "Changed status for $name, $outage_ocurrence" | ||
| else | ||
| @warn "$name status $current_status, outage draw: $outage_ocurrence" | ||
| available_status_change_parameter.values[name, 1] = outage_ocurrence |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| available_status_change_parameter.values[name, 1] = outage_ocurrence | |
| available_status_change_parameter.values[name, 1] = outage_ocurrence |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
PowerSimulations.jl/src/simulation/simulation_state.jl
Lines 341 to 352 in 79571e6
|
Performance Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.