Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix minor bug in TRT-LLM deployment #11714

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Conversation

oyilmaz-nvidia
Copy link
Collaborator

What does this PR do ?

Fixes a minor bug deploying trt-llm models

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
@oyilmaz-nvidia oyilmaz-nvidia added NLP bug Something isn't working r2.1.0 Run CICD labels Dec 25, 2024
@oyilmaz-nvidia oyilmaz-nvidia enabled auto-merge (squash) December 25, 2024 02:38
Copy link
Contributor

[🤖]: Hi @oyilmaz-nvidia 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@oyilmaz-nvidia oyilmaz-nvidia merged commit 805a70e into main Dec 31, 2024
372 of 548 checks passed
@oyilmaz-nvidia oyilmaz-nvidia deleted the onur/fix-trt-llm-deploy branch December 31, 2024 10:50
ko3n1g pushed a commit that referenced this pull request Dec 31, 2024
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
ko3n1g added a commit that referenced this pull request Jan 8, 2025
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Co-authored-by: Onur Yilmaz <35306097+oyilmaz-nvidia@users.noreply.github.com>
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Abhinav Garg <abhgarg@nvidia.com>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working NLP r2.1.0 Run CICD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants