Cmake fixes #59
Merged
Cmake fixes #59
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subprojects do not set version numbers, so use the top-level. Also quote to make sure the `VERSION` doesn't get set to `SOVERSION`.
Otherwise a `VISRTX_BUILD_RTX_DEVICE=ON` build can end up without the device just because, e.g., CUDA is too old. It's more friendly to acknowledge the request and say "no, the environment is insufficient" than to silently disable components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor followup to #58 after I noticed this in the build logs:
We're also missing the VisRTX bits because our CUDA is (soon to be "was") too old. Make noise about this at configure time instead of a
find_package(VisRTX)time.