Add warning for difference of application identifier. #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 |
1 similar comment
|
💔 |
petekanev
suggested changes
Aug 2, 2017
| @@ -721,6 +721,26 @@ copyTypings.onlyIf({ | |||
| generateTypescriptDefinitions.didWork; | |||
| }) | |||
|
|
|||
| task validateAppIdMatch { | |||
| doLast { | |||
There was a problem hiding this comment.
Please check if the build is happening in debug or release - https://github.com/NativeScript/android-runtime/blob/b74218bfd5d0e57087dcc0473366f76d34ff6433/build-artifacts/project-template-gradle/build.gradle#L84
There is no point in the user seeing the warning if they are preparing to release their app with an applicationId they themselves put in the app.gradle.
petekanev
approved these changes
Aug 2, 2017
|
💚 |
KristianDD
deleted the
kddimitrov/fix-missing-warning-mismatch-app-identifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User can change the application identifier inside his app.gradle file, but NativeScript LiveSync works with the one inside package.json. This causes the NativeScript CLI to not work as expected.
Does your commit message include the wording below to reference a specific issue in this repo?
Fixes NativeScript/nativescript-cli#2825
Related Pull Requests
NativeScript/nativescript-cli#3033
Does your pull request have unit tests?
Steps to tests.