Fix simulator identifier not verified before startEmulator. #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Jul 27, 2017
lib/iphone-simulator-xcode-simctl.ts
Outdated
| private verifyDevice(device?: IDevice): void { | ||
| const availableDevices = this.getDevices(); | ||
|
|
||
| if(_.find(availableDevices, { id: device.id })){ |
There was a problem hiding this comment.
I would invert the if:
if(!_.find(availableDevices, { id: device.id })) {
errors.fail(`No simulator image available for device identifier '${device.id}'.`);
}This way you can skip the return inside the method.
KristianDD
force-pushed
the
kddimitrov/fix-no-device-identifier-check
branch
from
d17db2c to
fc89f28
Compare
KristianDD
force-pushed
the
kddimitrov/fix-no-device-identifier-check
branch
from
fc89f28 to
12f123a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for NativeScript/nativescript-cli#2728. Now an exception is thrown if no simulator image is available for the specified identifier.