Skip to content

Running custom builds (or nightlies) breaks with new TNS CLI Master #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NathanaelA opened this issue Nov 5, 2015 · 4 comments
Closed
Assignees
Labels
Milestone

Comments

@NathanaelA
Copy link
Contributor

I upgraded to v1.5 nightly of everything 2015/11/04; but I ran into a issue with it that required me to disable some code inside the tns command line tool.

Here is the problem:
When you do a tns prepare (or anything internally does a tns prepare) it runs a function called NpmInstallationManager.prototype.isShasumOfPackageCorrect
Well, this function attempts to do a npm view tns-android@1.5.0 (or whatever version the built runtime is labeled). Of course since this is a compiled master installed using --frameworkPath; this sha will not be in the npm log. So npm fails to be to get a sha hash. If you label the custom runtime 1.4 (i.e. whatever is current) then of course the sha hash won't match.

I haven't had these problems ever before; so I am "assuming" this code is new in the master branch of the CLI; or their is some other bug that is causing a prepare to force a sha check of the runtimes which will for sure fail.

@teobugslayer teobugslayer added this to the 1.5.0 milestone Nov 6, 2015
@teobugslayer teobugslayer self-assigned this Nov 6, 2015
@teobugslayer
Copy link
Contributor

Hi @NathanaelA, which version of CLI are you using? I cannot reproduce this behavior with CLI from master.

@NathanaelA

This comment was marked as abuse.

@NathanaelA

This comment was marked as abuse.

@teobugslayer
Copy link
Contributor

Thanks for the repro case, I'll have a look at the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants