Out of the box support for application id in plugins #1408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the unneeded logic that merges configuration files
| @@ -547,94 +545,5 @@ describe("Plugins service", () => { | |||
| mockBeginCommand(testInjector, expectedErrorMessage); | |||
| pluginsService.prepare(pluginJsonData, "android").wait(); | |||
| }); | |||
| it("merges AndroidManifest.xml and produces correct xml", () => { | |||
There was a problem hiding this comment.
Maybe it is better this test to be rewritten for ios platform
|
This change should be mentioned in the docs. Consider creating a PR against the docs repo, |
|
👍 |
Fatme
pushed a commit
that referenced
this pull request
Jan 22, 2016
Out of the box support for application id in plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1026
Removes the unneeded logic that merges configuration files