Skip to content

Speed up livesync on android device #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2016

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jan 22, 2016

Related: #921

@rosen-vladimirov rosen-vladimirov force-pushed the fatme/shasums-on-android branch 2 times, most recently from 31e0aaa to 05fc45b Compare February 4, 2016 14:37
return ((): string =>{
let adb = this.$injector.resolve(AndroidDebugBridge, { identifier: this.device.deviceInfo.identifier });
let deviceHashService = this.$injector.resolve(AndroidDeviceHashService, {adb: adb, appIdentifier: this.appIdentifier});
let hashFile = this.$options.force ? null : deviceHashService.doesShasumFileExistsOnDevice().wait(); // introduce new method in deviceHashService and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this comment

@rosen-vladimirov
Copy link
Contributor

ping @teobugslayer - I've changed hash file to be JSON (check the last commit)

@dtopuzov
Copy link
Contributor

dtopuzov commented Feb 5, 2016

👍

@teobugslayer
Copy link
Contributor

Squash and 👍

Optimize the usage of `tns livesync android` command. In case your project is huge, every time you use it, the full project will be transferred to device.
Persist all file hashes of project's files and next time when command is executed transfer only the changed ones.
The json which contains hashes information should be on device, so when the device is attached to another PC, where the same project is developed, we'll still transfer only the changed files.
Related:  #921
@rosen-vladimirov rosen-vladimirov force-pushed the fatme/shasums-on-android branch from 3ee8866 to 11221ae Compare February 5, 2016 14:01
rosen-vladimirov added a commit that referenced this pull request Feb 5, 2016
@rosen-vladimirov rosen-vladimirov merged commit 5e70b96 into master Feb 5, 2016
@rosen-vladimirov rosen-vladimirov deleted the fatme/shasums-on-android branch February 5, 2016 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants