Fix first unit tests execution #2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First call to `tns test <platform>` always fails as the file with Karma configuration is not sent to device. The reason is that it's craeted in `node_modules/unit-test-runner` after the project is prepared. The second execution of the command will include the file, but it may not be correct. It's regenerated, but again after the project is prepared. Fix the `test-execution-service` to prepare the project after the configuration file is created. Fixes #1636 and possibly #2016 Fixes the problem in Travis builds that console hangs and travis builds never end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First call to
tns test <platform>always fails as the file with Karma configuration is not sent to device. The reason is that it's created innode_modules/unit-test-runnerafter the project is prepared.The second execution of the command will include the file, but it may not be correct. It's regenerated, but again after the project is prepared.
Fix the
test-execution-serviceto prepare the project after the configuration file is created.Fixes #1636 and possibly #2016
Fixes the problem in Travis builds that console hangs and travis builds never end (prove of concept here: rosen-vladimirov/ns-unit-test-travis#1 )