fix: Plugin remove command fails in case plugin name has dot #3459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case plugin name has dot (`.`) in its name, the `plugin remove` command fails. The reason is the way we are trying to remove plugin related data from the `nativescript` key of application's package.json. We are using `.` to concatenate the keys inside nativescript key and later we are trying to split by `.` in order to find which key should be deleted. This works in most of the cases, but when the plugin name has `.` in it, our logic fails as the split operation finds the dot. Fix this by using some symbols that are not allowed in npm for plugins names. Use symbols that will rarely be used in the same sequence.
|
run ci |
Fatme
approved these changes
Mar 15, 2018
Mitko-Kerezov
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case plugin name has dot (
.) in its name, theplugin removecommand fails.The reason is the way we are trying to remove plugin related data from the
nativescriptkey of application's package.json.We are using
.to concatenate the keys inside nativescript key and later we are trying to split by.in order to find which key should be deleted.This works in most of the cases, but when the plugin name has
.in it, our logic fails as the split operation finds the dot.Fix this by using some symbols that are not allowed in npm for plugins names. Use symbols that will rarely be used in the same sequence.
Fixes #3451