Skip to content

Fix connect to port #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Fix connect to port #3837

merged 2 commits into from
Aug 23, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Aug 23, 2018

PR Checklist

What is the current behavior?

Reconnect to dev tools dialog is shown when livesyncing to iOS simulator when debug command is executed.

What is the new behavior?

Reconnect to dev tools dialog is not shown when livesyncing to iOS simulator when debug command is executed.

Steps to reproduce:

  1. Open new project from Sidekick
  2. Click run on device with debugger
  3. Make change in some .js file
  4. Reconnect to dev tools dialog is shown

@Fatme Fatme merged commit c2d261a into release Aug 23, 2018
@Fatme Fatme deleted the fatme/fix-ios-emulator-debugger branch August 23, 2018 11:29
@rosen-vladimirov rosen-vladimirov added this to the 4.2.3 milestone Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants