Skip to content

chore: stop webpack compiler when ctrl+c is pressed while executing tns preview --bundle command #3897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2018
Merged

chore: stop webpack compiler when ctrl+c is pressed while executing tns preview --bundle command #3897

merged 1 commit into from
Sep 17, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Sep 17, 2018 •
edited
Loading

PR Checklist

What is the current behavior?

Webpack process does not stop when ctrl+c is pressed while executing tns preview --bundle command

What is the new behavior?

Webpack process stops when ctrl+c is pressed while executing tns preview --bundle command

Should be merged with this: NativeScript/nativescript-dev-webpack#661

@Fatme Fatme mentioned this pull request Sep 17, 2018
Merged
5 tasks
rosen-vladimirov
rosen-vladimirov approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After green build

@Fatme Fatme merged commit 28a0423 into master Sep 17, 2018
@Fatme Fatme deleted the fatme/fix-webpack branch September 17, 2018 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosen-vladimirov rosen-vladimirov rosen-vladimirov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fatme @rosen-vladimirov