Stop calling metadata generator and build twice for android platform #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, the project template will supply a custom ants hook to do the work Also, cache the platformData Also, starting ant through the user command interpreter falling back to cmd See NativeScript/android#47
|
✅ |
|
👍 |
| @@ -422,16 +403,6 @@ class AndroidProjectService implements IPlatformProjectService { | |||
| }).future<void>()(); | |||
| } | |||
|
|
|||
| private checkJava(): IFuture<void> { | |||
There was a problem hiding this comment.
Do you need to remove this function?
There was a problem hiding this comment.
It is unused. We used to check for java because we needed to run it manually. Now, we do not this.
|
👍 |
1 similar comment
|
👍 |
teobugslayer
added a commit
that referenced
this pull request
Apr 6, 2015
Stop calling metadata generator and build twice for android platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, the project template will supply a custom ants hook to do the work
Also, cache the platformData
Also, starting ant through the user command interpreter falling back to cmd
See NativeScript/android#47
This pR is against the release branch. The one against master will be closed (#405)