Skip to content

fix: reset devices list when stopLiveSync method is called #4158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Nov 20, 2018

When stopLiveSync method is called, we want to reset devices list and emit deviceLost event for all connected devices.

PR Checklist

What is the current behavior?

deviceLost event is not emitted when there are connected devices and stopLiveSync method is called

What is the new behavior?

deviceLost event is emitted when there are connected devices and stopLiveSync method is called

When stopLiveSync method is called, we want to reset devices list and receive deviceLost event for all connected devices.
@Fatme Fatme added this to the 5.0.2 milestone Nov 21, 2018
@Fatme Fatme merged commit b2f87bf into release Nov 21, 2018
@Fatme Fatme deleted the fatme/reset-devices-on-stop-livesync branch November 21, 2018 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants