Skip to content

fix: remove duplicated platforms from project's podfile #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Feb 4, 2019

fixes #3604

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@Fatme Fatme changed the base branch from master to release-patch February 8, 2019 13:05
@Fatme Fatme added this to the 5.2.1 milestone Feb 8, 2019
@Fatme Fatme added the bug label Feb 8, 2019
@Fatme Fatme force-pushed the fatme/fix-multiple-platforms-pod branch 2 times, most recently from e553bf9 to 2283da8 Compare February 11, 2019 07:30
@Fatme Fatme force-pushed the fatme/fix-multiple-platforms-pod branch from 2283da8 to 363b336 Compare February 18, 2019 21:57
@Fatme
Copy link
Contributor Author

Fatme commented Feb 20, 2019

run ci

Fatme and others added 3 commits February 22, 2019 14:10
When removing platforms section, fix the regexp, so the removal procedure will keep the file the same as before the platform section was added. Currently, after removing the platform section, the file had additional empty lines inside it.
@rosen-vladimirov rosen-vladimirov changed the base branch from release-patch to release February 22, 2019 12:11
@rosen-vladimirov rosen-vladimirov force-pushed the fatme/fix-multiple-platforms-pod branch from 667e2a5 to 0472afb Compare February 22, 2019 12:11
@ghost ghost added the new PR label Feb 22, 2019
@rosen-vladimirov rosen-vladimirov merged commit 534b2db into release Feb 22, 2019
@rosen-vladimirov rosen-vladimirov deleted the fatme/fix-multiple-platforms-pod branch February 22, 2019 14:19
@ghost ghost removed the new PR label Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants