Skip to content

fix: add new line at the end of the platform's section in order to remove it correctly #4395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Feb 26, 2019

Steps to reproduce:

  1. tns create myApp --js
  2. tns plugin add nativescript-imagepicker && tns plugin add nativescript-facebook
  3. Replace the content of ./node_modules/nativescript-imagepicker/platforms/ios/Podfile with platform: ios, '9.0'
  4. Replace the content of ./node_modules/nativescript-facebook/platforms/ios/Podfile with platform: ios, '10.0'
  5. Add Podfile in ./app/App_Resources/iOS with the following content platform: ios: '8.0'
  6. Execute tns prepare ios
  7. Remove ./app/App_Resources/iOS/Podfile
  8. Execute tns prepare ios

Expected behavior: It should pass correctly and the content of platforms/ios/Podfile should be

...
# NativeScriptPlatformSection /node_modules/nativescript-facebook/platforms/ios/Podfile with 10.0
       platform :ios, '10.0'
# End NativeScriptPlatformSection
end

Actual behavior: It fails with [!] Invalid Podfile file: syntax error, unexpected end-of-input, expecting keyword_end. error and the the content of platforms/ios/Podfile is:

...
# NativeScriptPlatformSection /node_modules/nativescript-facebook/platforms/ios/Podfile with 10.0
       platform :ios, '10.0'
# End NativeScriptPlatformSectionend

PR Checklist

Fixes/Implements/Closes #[Issue Number].

Rel to: #3604

…move it correctly

Steps to reproduce:
1. `tns create myApp --js`
2. `tns plugin add nativescript-imagepicker` && `tns plugin add nativescript-facebook`
3. Replace the content of `./node_modules/nativescript-imagepicker/platforms/ios/Podfile` with `platform: ios, '9.0'`
4. Replace the content of `./node_modules/nativescript-facebook/platforms/ios/Podfile` with `platform: ios, '10.0'`
5. Add Podfile in `./app/App_Resources/iOS` with the following content `platform: ios: '8.0'`
6. Execute `tns prepare ios`
7. Remove `./app/App_Resources/iOS/Podfile`
8. Execute `tns prepare ios`

Expected behavior: Is should pass correctly and the content of `platforms/ios/Podfile` should be
```
...
# NativeScriptPlatformSection /node_modules/nativescript-facebook/platforms/ios/Podfile with 10.0
       platform :ios, '10.0'
# End NativeScriptPlatformSection
end
```

Actual behavior: It fails with `[!] Invalid `Podfile` file: syntax error, unexpected end-of-input, expecting keyword_end.` error and the the content of `platforms/ios/Podfile` is:
```
...
# NativeScriptPlatformSection /node_modules/nativescript-facebook/platforms/ios/Podfile with 10.0
       platform :ios, '10.0'
# End NativeScriptPlatformSectionend
```
@Fatme Fatme added the bug label Feb 26, 2019
@Fatme Fatme added this to the 5.2.1 milestone Feb 26, 2019
@Fatme Fatme self-assigned this Feb 26, 2019
@cla-bot cla-bot bot added the cla: yes label Feb 26, 2019
@ghost ghost added new PR and removed cla: yes labels Feb 26, 2019
@Fatme Fatme merged commit 76b1580 into release Feb 26, 2019
@Fatme Fatme deleted the fatme/fix-pods-remove branch February 26, 2019 07:42
@ghost ghost removed the new PR label Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants