Enable image resources from App_Resources in iOS #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
|
✅ |
|
👍 |
| _.each(imagesToAdd, image => project.addResourceFile(path.join(this.platformData.appResourcesDestinationDirectoryPath, image))); | ||
|
|
||
| let imagesToRemove = _.difference(imageNames, currentImageNames); | ||
| this.$logger.trace(`Images to remove from xcode project: ${ imagesToRemove.length !== 0 ? imagesToRemove.join(", ") : "" }`); |
There was a problem hiding this comment.
You can omit the length check.
builder@ab-linuxbpc-1:~/.ssh$ node
> [].join(", ")
''
>
|
✅ |
| } | ||
|
|
||
| private get pbxProj(): any { | ||
| let project = new xcode.project(this.pbxProjPath); |
There was a problem hiding this comment.
is it expected to return new project every time you try using the property pbxProj?
There was a problem hiding this comment.
This function is called only one time - https://github.com/NativeScript/nativescript-cli/pull/590/files#diff-b673f137deb4afccccc0bd5f1572c2a0R229
There was a problem hiding this comment.
So we can make it a function instead of property then.
|
👍 after addressing @rosen-vladimirov and @ligaz comments. |
|
✅ |
|
✅ |
|
✅ |
|
👍 |
|
✅ |
|
✅ |
Fatme
pushed a commit
that referenced
this pull request
Jun 26, 2015
Enable image resources from App_Resources in iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #520
NativeScript/ios-jsc#202