Add platform on all commands #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -204,7 +205,7 @@ export class PlatformService implements IPlatformService { | |||
| public runPlatform(platform: string): IFuture<void> { | |||
| return (() => { | |||
| platform = platform.toLowerCase(); | |||
|
|
|||
There was a problem hiding this comment.
😿
I'll remove this change
|
✅ |
When you execute `tns run <platform>`, but you have forgotten to add the platform before that, you go in inconsistent state. Make sure to add the platform for the user when one of the following is executed: * `tns prepare <platform>` * `tns build <platform>` * `tns run <platform>` * `tns update <platform>@<version>` - this will add the specified version in case you have not added the platform before that. * `tns emulate <platform>` This way we simplify the workflow, now you can just do: 1) `tns create app1` 2) `tns run android --path app1` And the application will run on your attached device. Resolves #774 Part of the implementation of: #475
teobugslayer
force-pushed
the
vladimirov/improve-platform-commands
branch
from
8331c22 to
9a38ec1
Compare
|
✅ |
|
Excellent! 👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Aug 13, 2015
…-commands Add platform on all commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you execute
tns run <platform>, but you have forgotten to add the platform before that, you go in inconsistent state. Make sure to add the platform for the user when one of the following is executed:tns prepare <platform>tns build <platform>tns run <platform>tns update <platform>@<version>- this will add the specified version in case you have not added the platform before that.tns emulate <platform>This way we simplify the workflow, now you can just do:
tns create app1tns run android --path app1And the application will run on your attached device.
Resolves #774
Part of the implementation of: #475