This repository was archived by the owner on Aug 7, 2021. It is now read-only.
refactor: get app directory from CLI #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sis0k0
force-pushed
the
sis0k0/app-path-env
branch
5 times, most recently
from
82b4fd5 to
3591fc6
Compare
This was referenced Mar 17, 2018
index.js
Outdated
| throw new Error("app/package.json must contain a `main` attribute."); | ||
| exports.getAotEntryModule = function (appDirectory = APP_DIR) { | ||
| const entry = getPackageJsonEntry(appDirectory); | ||
| const aotEntry = `${entry}.aot.ts`; |
There was a problem hiding this comment.
Does the entry point need to be .ts 💭
There was a problem hiding this comment.
Yep, the Angular compiler needs a ts file.
lib/compiler.js
Outdated
| } | ||
|
|
||
| function getProjectDir($projectData) { | ||
| const projectDir = safeGet($projectData, "projectDir"); |
There was a problem hiding this comment.
I don't believe this is necessary - CLI's $projectData always has projectDir property - if it doesn't the initial creation of the $projectData class would have failed long before we get here
projectHelpers.js
Outdated
| @@ -3,6 +3,10 @@ const fs = require("fs"); | |||
| const semver = require("semver"); | |||
| const { EOL } = require("os"); | |||
|
|
|||
| const { getProjectData, PROJECT_DATA_GETTERS } = require("./nsCliHelpers"); | |||
|
|
|||
| const APP_DIR = "app"; | |||
There was a problem hiding this comment.
You can reuse this constant here
|
👍 |
SvetoslavTsenov
approved these changes
Mar 20, 2018
Mitko-Kerezov
approved these changes
Mar 20, 2018
NativeScriptModule
SvetoslavTsenov
force-pushed
the
sis0k0/app-path-env
branch
from
ee05e7a to
3ef11ec
Compare
|
test |
1 similar comment
|
test |
|
test |
SvetoslavTsenov
approved these changes
Mar 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourceDirandappResourcesDirwhen starting webpack from theprojectDataservice.sourceDirandappResourcesDirin webpack configs from env object.appPathvalue from the project data. Defaults toapp.getEntryModule.resolves #436