fix(iOS): open from available presentedViewController #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for presentedViewController and present from it. Allow opening from already presented modal. Addresses issue NativeScript#214 and NativeScript#79
ghost
added
the
elena-p
suggested changes
Jan 3, 2019
There was a problem hiding this comment.
You can check the status of the CI checks here in github and you can view the results by going directly to https://travis-ci.org/NativeScript/nativescript-imagepicker/pull_requests.
Each time you make changes to the PR, a new build will be triggered but it might take some time for it to finish, since it runs on a shared environment along with other open-source projects.
Unfortunately, our UI tests use env variables that are not exposed by PR made from forks https://docs.travis-ci.com/user/pull-requests#pull-requests-and-security-restrictions, so they will fail, but we will then review the tests and merge manually.
elena-p
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for presentedViewController and present from it.
Allow opening from already presented modal.
Addresses issue #214 and #79
PR Checklist
What is the current behavior?
Can not open ImagePicker modal from existing modal
What is the new behavior?
Open ImagePicker from already presentedViewController if available.