bugfix for misuse of bytes
and str
& refinement
#49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found a few more bugs during use. Some of them are caused by misuse of
bytes
andstr
(e.g., to check if abytes
is in a Counter whose keys arestr
, which will always lead toFalse
).There are also some trivial yet fatal problems like
dict.keys()[0]
ordict.items()[0]
, which is illegal in Python 3.x (it should belist(dict.keys())[0]
).Btw, It looks that all problems are caused by code migration from Python 2 to 3.
Have fixed them and refined the code.