Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for misuse of bytes and str & refinement #49

Merged
merged 2 commits into from
Dec 23, 2023
Merged

bugfix for misuse of bytes and str & refinement #49

merged 2 commits into from
Dec 23, 2023

Conversation

seekamoon
Copy link
Contributor

Hi,
I found a few more bugs during use. Some of them are caused by misuse of bytes and str (e.g., to check if a bytes is in a Counter whose keys are str, which will always lead to False).
There are also some trivial yet fatal problems like dict.keys()[0] or dict.items()[0], which is illegal in Python 3.x (it should be list(dict.keys())[0]).

Btw, It looks that all problems are caused by code migration from Python 2 to 3.

Have fixed them and refined the code.

@Neo23x0
Copy link
Owner

Neo23x0 commented Dec 23, 2023

Yeah, possible. Many thanks.
Since I'm not using the Python-based generator in my daily work anymore, I didn't notice these bugs.

@Neo23x0 Neo23x0 merged commit 97b466f into Neo23x0:master Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants