Add close_range() system call #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardobranco777
force-pushed
the
close_range
branch
5 times, most recently
from
9c2c2ee to
b118f47
Compare
ricardobranco777
force-pushed
the
close_range
branch
from
b118f47 to
673e298
Compare
ricardobranco777
force-pushed
the
close_range
branch
from
673e298 to
4b530cb
Compare
|
I think UNSHARE was implemented before and it was the same way sharing is done and undone in the clone system call. I added it back. I patched, I am doing a build now and will fix the sets. |
zoulasc
reviewed
Mar 25, 2025
| return EINVAL; | ||
| if (lflags & LINUX_CLOSE_RANGE_CLOEXEC) | ||
| flags |= CLOSE_RANGE_CLOEXEC; | ||
| SCARG(&crap, flags) = flags; |
There was a problem hiding this comment.
need to set first/last here too. (I fixed it already).
zoulasc
reviewed
Mar 25, 2025
| @@ -102,6 +102,7 @@ ASM=\ | |||
| chdir.S chflags.S chmod.S chown.S chroot.S \ | |||
| clock_getcpuclockid2.S \ | |||
| __clock_getres50.S __clock_gettime50.S \ | |||
| close_range.S \ | |||
There was a problem hiding this comment.
Need to also add manpage (fixed it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt existing code in
compat_linuxforclose_rangeand make it use the new native system call.The existing test code for
closefrom(3)was adapted and extended forclose_range(2).The manpage was adapted from FreeBSD using the Linux names for the parameters:
https://man.freebsd.org/cgi/man.cgi?query=close_range&sektion=2&n=1
Fixes kern/59081
CLOSE_RANGE_UNSHAREwas removed as it doesn't make sense on NetBSD which lacksunshare(2). From the Linux documentation: