Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Argo workflows joins failing with wide foreach flows #1655

Closed
wants to merge 2 commits into from

Conversation

saikonen
Copy link
Collaborator

Partial remedy to the issue with large foreach flows input-paths being repeated in the ARGO_TEMPLATE multiple times, exceeding the max size for it.

closes #1538

@saikonen saikonen requested a review from savingoyal December 14, 2023 00:05
@saikonen saikonen marked this pull request as ready for review December 14, 2023 19:17
@saikonen
Copy link
Collaborator Author

saikonen commented Dec 18, 2023

I think we should proceed with alternative solution where we pass state through the configured datastore, instead of relying on Argo Workflow parameters, as even the fix in this PR does not solve the scaling issues completely due to the way Argo materializes the parameter values in the ARGO_TEMPLATE env var, and the input parameters for a foreach join being arbitrarily large.

The current fix relies on reading the template json from environment, but as there are proposals such as argoproj/argo-workflows#12325 already in the works, this might break with future versions of Argo.

@shrinandj
Copy link
Contributor

This looks good to me!

@rohanrebello
Copy link
Contributor

I've tested that this PR works for up to 3000-way foreach's on AWS

@tslott
Copy link

tslott commented Jan 12, 2024

Can this be merged?

@saikonen
Copy link
Collaborator Author

have to close this PR as a dead end due to the direction that Argo Workflows took with the new handling of oversized ARGO_TEMPLATE where they offload it to disk as a ConfigMap, making it not parseable in the way I had in mind in this.

This PR being only a partial fix at best lead me to a different approach, one which should be in review now and hopefully a proper solution to the issue at hand: #1704

@saikonen saikonen closed this Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argo Workflows template exceeds max size with preceding large foreach
4 participants