inject keyrings.google-artifactregistry-auth for private GCP PyPi registry #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhur-ob
changed the title
|
Tried with the following: where from metaflow import FlowSpec, step, pypi
class PetFlow(FlowSpec):
@pypi(python='3.10.13',
packages={'swagger-petstore-open-api-3-0-client': '1.0.11'})
@step
def start(self):
from swagger_petstore_open_api_3_0_client.api import pet
self.next(self.end)
@step
def end(self):
pass
if __name__ == '__main__':
PetFlow()with output of The generated But we still get the following issue: |
madhur-ob
changed the title
|
@savingoyal @saikonen this fixes and I can confirm the PR works now... while output of |
saikonen
reviewed
Mar 27, 2024
| @@ -258,6 +258,15 @@ def indices(self, prefix): | |||
| return index, extras | |||
|
|
|||
| def _call(self, prefix, args, env=None, isolated=True): | |||
| # `--no-input` flag should not be passed when credentials | |||
There was a problem hiding this comment.
can you go into a bit more detail why removing the --no-input was necessary? we don't want to require/enable any user interaction with the pip3 calls.
There was a problem hiding this comment.
Honestly, I am not sure. What I observed was that perhaps keyring tries to inject the creds dynamically using the json file passed to the env variable. And that apparently doesn't work when we use --no-input
There was a problem hiding this comment.
this will likely break the pypi solver. can we roll back this PR and discuss this issue?
savingoyal
reviewed
Mar 27, 2024
| @@ -254,6 +245,14 @@ def get_environment(self, step): | |||
| msg += "step is not yet supported. Use one of @pypi or @conda only." | |||
| raise CondaEnvironmentException(msg) | |||
|
|
|||
| # Certain packages are required for metaflow runtime to function correctly. | |||
There was a problem hiding this comment.
does line 241:246 work as expected with this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1658
Present https://anaconda.org/conda-forge/keyrings.google-artifactregistry-auth
and on https://pypi.org/project/keyrings.google-artifactregistry-auth/