Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for falsy values instead of just None #1786

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

madhur-ob
Copy link
Collaborator

@madhur-ob madhur-ob commented Mar 29, 2024

Reason: a click option that has default as None and multiple as True gives an empty tuple i.e. () when the option is not supplied, which is weird, thus the issue

@romain-intel
Copy link
Contributor

Merging as this is considered a hotfix by @madhur-ob

@romain-intel romain-intel merged commit c653b9f into Netflix:master Mar 29, 2024
34 checks passed
@madhur-ob madhur-ob deleted the falsy-values-for-log-options branch March 29, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants