Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for review] replace pull_request_target #1790

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

darinyu
Copy link
Collaborator

@darinyu darinyu commented Apr 2, 2024

We are replacing pull_request_target because it could be triggered automatically against untrusted PRs allowing malicious actors to run code and exfiltrate secrets. Replacing it with pull_request could solve the issue.

More in this article: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

@romain-intel romain-intel merged commit 2dad8d6 into master Apr 2, 2024
33 of 35 checks passed
@romain-intel romain-intel deleted the fix_security_loophole_pr_trigger branch April 2, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants