Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Metaflow local config init #1967

Merged
merged 1 commit into from
Aug 17, 2024
Merged

fix: Metaflow local config init #1967

merged 1 commit into from
Aug 17, 2024

Conversation

saikonen
Copy link
Collaborator

fixes issue with metaflow local config initialization

romain-intel
romain-intel approved these changes Aug 17, 2024
View reviewed changes
Copy link
Contributor

@romain-intel romain-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yes, you could have a config but not a local config so this makes sense. Good catch.

@romain-intel romain-intel merged commit ee5a4db into master Aug 17, 2024
26 checks passed
@romain-intel romain-intel deleted the fix/metaflow-local-config branch August 17, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-intel romain-intel romain-intel approved these changes

@savingoyal savingoyal Awaiting requested review from savingoyal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saikonen @romain-intel