Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: passing kubernetes compute pool option #1968

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

saikonen
Copy link
Collaborator

@saikonen saikonen commented Aug 19, 2024

fixes issue with launching kubernetes tasks with a default node_selector. Introduced in #1952

is the else block required at all? the default dict messes up with the value of node_selector being passed to the CLI, where parsing fails.

2024-08-19 12:06:18.037 [1450/start/4611 (pid 74904)] in kube-cli step the node_selector is: {}
2024-08-19 12:06:19.178 [1450/start/4611 (pid 74904)] Kubernetes error:
2024-08-19 12:06:19.178 [1450/start/4611 (pid 74904)] Unable to parse kubernetes list: {}

@saikonen saikonen requested a review from savingoyal August 19, 2024 09:15
@saikonen saikonen changed the title fix: issue with kubernetes node_selector config fix: passing kubernetes compute pool option Aug 19, 2024
…pool node-selector. add ability to skip passing some attributes to step CLI
@saikonen saikonen merged commit 5cfc235 into master Aug 20, 2024
25 of 26 checks passed
@saikonen saikonen deleted the fix/kubernetes-label-issue branch August 20, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant