Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: boto3 bootstrap cleanup #1992

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: boto3 bootstrap cleanup #1992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metaflow/metaflow_environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def _get_download_code_package_cmd(self, code_package_url, datastore_type):
# Boto3 does not play well with passing None or an empty string to endpoint_url
return "{python} -c '{script}'".format(
python=self._python(),
script='import boto3, os; ep=os.getenv(\\"METAFLOW_S3_ENDPOINT_URL\\"; (boto3.client(\\"s3\\", endpoint_url=ep) if ep else boto3.client(\\"s3\\")).download_file(\\"%s\\", \\"%s\\", \\"job.tar\\")'
script='import boto3, os; ep=os.getenv(\\"METAFLOW_S3_ENDPOINT_URL\\"); boto3.client(\\"s3\\", **({endpoint_url=ep} if ep else {})}).download_file(\\"%s\\", \\"%s\\", \\"job.tar\\")'
% (bucket, s3_object),
)
elif datastore_type == "azure":
Expand Down
Loading