patch: add fallbacks to kube kill #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikonen
merged commit 861cf5d
into
feature/backwards-compatible-kubernetes-kill
1 check passed
savingoyal
pushed a commit
that referenced
this pull request
Sep 16, 2024
* backwards compatible kubernetes list and kill * cleanup imports * address comments * patch: add fallbacks to kube kill (#2025) * add fallbacks to kube kill * block killing pods managed by argo-workflows * more robust job_name inference * fetch pod job name from labels instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacked PR for backwards compatible Kubernetes kill.
Adds fallbacks for cases where user permissions do not allow direct pod exec.
guard against being able to kill pods launched by argo-workflows