Some shallow git fetching improvements #9410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more efficient, and necessary when using shallow=1 with a rev.
github-actions
bot
added
with-tests
DavHau
added a commit
to DavHau/nix
that referenced
this pull request
Dec 29, 2023
DavHau
reviewed
Dec 29, 2023
Comment on lines
-54
to
-56
| out=$(nix eval --impure --raw --expr "builtins.fetchGit { url = file://$repo; rev = \"$devrev\"; }" 2>&1) || status=$? | ||
| [[ $status == 1 ]] | ||
| [[ $out =~ 'Cannot find Git revision' ]] |
There was a problem hiding this comment.
The fact that these checks had to be removed indicates that the behavior changed in an incompatible manner.
Proposal to revert these changes: #9668
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There were part of my libgit2 branch but I forgot to push them.
Context
Priorities
Add 👍 to pull requests you find important.