Skip to content

Changed anchor tags from camelCase to snake-case, Fix for issue #1726 #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Changed anchor tags from camelCase to snake-case, Fix for issue #1726 #1743

wants to merge 1 commit into from

Conversation

MariusLerf
Copy link

@MariusLerf MariusLerf commented Nov 8, 2018

Fix for #1726

@ramsey
Copy link

ramsey commented Nov 8, 2018

I guess the big question is: will GitHub fix the issue, or does this need to be merged to fix the issue? This is a problem on every repository that linked to anchors, so the OAI docs repo is not the only one affected.

@cebe
Copy link
Contributor

cebe commented Nov 8, 2018

According to Github support this was an unintentionally made breaking change and they are working on a solution. Given the fact that it is working for me right now, I assume they are rolling out the fix to a limited set of accounts or networks before applying it for all.

@cebe
Copy link
Contributor

cebe commented Nov 8, 2018

Btw: While this PR fixes it for master, it breaks external links to the spec, that refer to specific headlines and it does not fix it for links that point to a tag instead of master. So I'd prefer to wait for github fixing it instead of merging this. For future stability it might be wise to not rely on github for hosting it but to put it on the website instead.

@MariusLerf MariusLerf closed this Nov 13, 2018
@MikeRalphson
Copy link
Member

Thanks @cebe

For future stability it might be wise to not rely on github for hosting it but to put it on the website instead.

This is under development -- see #1564, though the markdown version will remain the source-of-truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants