Skip to content

[17.0][IMP] dms: Implement index_content and create dms_indexation mo… #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 17.0
Choose a base branch
from

Conversation

dakshesh-sttl
Copy link

…dule

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as indicated in #366 (review)

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments:

  • Check pre-commit errors.
  • Modify the PR title, e.g.: [17.0][ADD] dms_indexation: New module
  • Unify all changes in a single commit ([17.0][ADD] dms_indexation: New module for example).
  • Modify the module icon with the existing dms icon + attachment indexation combination (or if you prefer, you can use the one for default).
  • You can add files to the readme folder to describe the module and how to use it.
  • You are adding more stuff than necessary (the attachment_indexation module already takes care of that), I think the method should be very similar to https://github.com/odoo/odoo/blob/583e785fc6e2acababa5865a6e0e8e71f3df8a49/odoo/addons/base/models/ir_attachment.py#L384.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants