Skip to content

[MIG] hr_holidays_meeting_name #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 27, 2017

Conversation

adrienpeiffer
Copy link
Contributor

@adrienpeiffer adrienpeiffer commented Apr 14, 2017

No description provided.


This module allows to leave generated meeting name personalization according to the leave type.

this module depends on https://github.com/odoo/odoo/pull/9103.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrienpeiffer s/9103/16432


.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/116/8.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrienpeiffer s/8.0/10.0

This directory caches those eggs to prevent repeated downloads.

However, it is safe to delete this directory.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrienpeiffer Unwanted .eggs (should be added in the gitignore)

@adrienpeiffer adrienpeiffer force-pushed the 10.0-mig-hr_holidays_meeting_name-ape branch from d9cceae to 3026391 Compare October 3, 2017 08:47
@adrienpeiffer
Copy link
Contributor Author

Rewrite to avoid to depends on Odoo patch

Copy link

@ThomasBinsfeld ThomasBinsfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test 👍

@api.multi
def _prepare_holidays_meeting_values(self):
res = super(HrHolidays, self)._prepare_holidays_meeting_values()
if not self.holiday_status_id.use_leave_name_for_meeting and \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrienpeiffer for rec in self: you using api.multi

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrienpeiffer ops sorry didn't see you changed that in the next commit

Copy link

@zakiuu zakiuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@api.multi
def _prepare_holidays_meeting_values(self):
res = super(HrHolidays, self)._prepare_holidays_meeting_values()
if not self.holiday_status_id.use_leave_name_for_meeting and \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrienpeiffer ops sorry didn't see you changed that in the next commit

@feketemihai feketemihai merged commit fe97cb0 into OCA:10.0 Nov 27, 2017
nikul-serpentcs pushed a commit to nikul-serpentcs/hr that referenced this pull request Jan 20, 2018
* Add hr_holidays_meeting_name module

* Typo

* [MIG] hr_holidays_meeting_name

* [CHG] According upstream changes.

* [CHG] Rewrite hr_holidays_meeting_name witout Odoo patch. Add tests.

* [CHG] Ignore .eggs directory.
nikul-serpentcs pushed a commit to nikul-serpentcs/hr that referenced this pull request Jan 20, 2018
Fix _onchange_employee() arguments

OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex

[fix] `hr_employee_id` use deprecated `sequence.get_id()` (OCA#358)

[add] hr_employee_address_improved (OCA#357)

[ADD] hr_employee_category_parent (OCA#366)

* [ADD] hr_employee_category_parent

* [IMP] human readable name

[UPD] addons table in README.md

[ADD] setup.py

[ADD] hr_holiday_notify_employee_manager: Notify by mail the manager of the employee requesting the leave. (OCA#331)

OCA Transbot updated translations from Transifex

[MIG] hr_holidays_notify_employee_manager: Migration to 10.0

[10.0][ADD] hr_holidays_settings

[FIX] add company_id in view

hr_worked_days_from_timesheet

OCA Transbot updated translations from Transifex

[ADD] hr_worked_days_from_timesheet v10

[IMP] Improved code

[IMP] Improved code

[MIG] hr_employee_legacy_id

[FIX] update header

[UPD] addons table in README.md

[ADD] setup.py

[MIG] 10.0 porting hr_skill

[UPD] Move Skills menu into HR configuration and add widget m2m_tags in employee form view and add to contributors list

[UPD] Update copyright

[IMP] Add unit test to test nam_get function on hr_skill

Refactor code for pep-8

Add group to Skill menu

Fix imports & lost things in pull/300

[UPD] addons table in README.md

[ADD] setup.py

[MIG][9.0] hr_expense_analytic_plans module

OCA Transbot updated translations from Transifex

[MIG] hr_expense_analytic_distribution: Migration to 10.0

[REM] hr_expense_analytic_plans: Replaced by hr_expense_analytic_distribution

[UPD] addons table in README.md

[ADD] setup.py

[FIX] Fix issue with 2 invoices on the same partner and the same total amount (OCA#237)

On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible.

The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.

OCA Transbot updated translations from Transifex

[MIG] hr_expense_invoice: Migration to 10.0

[UPD] addons table in README.md

[ADD] setup.py

Update view in holidays status, to remove duplicated field on company_id. (OCA#405)

[FIX][hr_holidays_settings] Make 'Leave Types' view accessible (OCA#408)

[MIG] hr_holidays_meeting_name (OCA#334)

* Add hr_holidays_meeting_name module

* Typo

* [MIG] hr_holidays_meeting_name

* [CHG] According upstream changes.

* [CHG] Rewrite hr_holidays_meeting_name witout Odoo patch. Add tests.

* [CHG] Ignore .eggs directory.

[UPD] addons table in README.md

OCA Transbot updated translations from Transifex

[FIX] hr_employee_seniority permission problem

normally hr.contract are only readable by Employee / Officer and Employee / Managers,
not basic employees => we need compute_sudo to compute the employee's seniority otherwise
the employee cannot display his own record.

[FIX] employee seniority tests

[UPD] addons table in README.md

[FIX] holiday meeting name tests

Change the date to avoid conflicts with the demo data of
hr_holidays.

[IMP] hr_public_holidays: Improve README

[FIX] employee seniority search crash

[imp] hr_employee_id: ease override w/ custom ID

[UPD] addons table in README.md
sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
[BSSFL-458] Fix confirm multiple sale orders
i-vyshnevska pushed a commit to i-vyshnevska/hr that referenced this pull request Mar 5, 2019
* Add hr_holidays_meeting_name module

* Typo

* [MIG] hr_holidays_meeting_name

* [CHG] According upstream changes.

* [CHG] Rewrite hr_holidays_meeting_name witout Odoo patch. Add tests.

* [CHG] Ignore .eggs directory.
i-vyshnevska pushed a commit to i-vyshnevska/hr that referenced this pull request Mar 12, 2019
* Add hr_holidays_meeting_name module

* Typo

* [MIG] hr_holidays_meeting_name

* [CHG] According upstream changes.

* [CHG] Rewrite hr_holidays_meeting_name witout Odoo patch. Add tests.

* [CHG] Ignore .eggs directory.
quentingigon pushed a commit to quentingigon/hr that referenced this pull request Oct 11, 2019
* Add hr_holidays_meeting_name module

* Typo

* [MIG] hr_holidays_meeting_name

* [CHG] According upstream changes.

* [CHG] Rewrite hr_holidays_meeting_name witout Odoo patch. Add tests.

* [CHG] Ignore .eggs directory.
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants