-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] subreports #256
[ADD] subreports #256
Conversation
4c2a466
to
4348a7b
Compare
Hi, @sbidoul thanks! I ran the tests on the runbot, it seems to be working well. However, I don't know if I didn't know how to configure it, but the budget columns didn't work. Another very interesting feature that we did in the PR of v8, was the possibility for the user, when viewing the report, to navigate to the subreport by clicking on the cell. https://github.com/OCA/mis-builder/pull/153/files#diff-3678f60340076198a6cc144a9fa4a107L37 Can we help you in any way? Best regards |
Yes, that's expected. That should work after the refactoring. Regarding the drilldown I'm not sure. Currently the drilldown shows move lines or budget lines. I tend to think showing other reports could be confusing because there could be many of them for different periods, or different preset analytic filters. Maybe something could be possible with the the features that generates reports instances on the fly. Need to think about it.
Thanks for proposing! Let me go through the refactoring first. |
6003e7e
to
950b0cf
Compare
db23f5b
to
b309b43
Compare
b8cd29f
to
5da331b
Compare
b309b43
to
d196093
Compare
d196093
to
4fabda8
Compare
5da331b
to
ac88904
Compare
e71ad42
to
38d9912
Compare
@mileo in the end, budget with subreports is not that obvious. Budget by account will work though. So this specific PR is done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested a reports fetching KPIs from 3 others subreports : test ok
Fantastic :)
not UserError. Also, remove redundant onchange warnings.
d8a9afa
to
3fa1058
Compare
Merging into the 3.6 staging branch. People interested to test further can do so in #254 /ocabot merge |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at b0f71c4. Thanks a lot for contributing to OCA. ❤️ |
Closes #155
With this PR, you can add named "sub reports" on a report template.
When that is done, KPIs from sub reports can be used in expressions of the the parent report with the following syntax
<subreport name>.<kpi name>
.The code is WIP and will be refactored, but the concept and data model should be ok.cc/ @fclementic2c @mileo @JordiBForgeFlow