Skip to content

[18.0][MIG] pos_lot_barcode: Migration to 18.0. #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Apr 10, 2025

Conversation

BhaveshHeliconia
Copy link

No description provided.

grindtildeath and others added 26 commits March 18, 2025 12:30
Currently translated at 100.0% (9 of 9 strings)

Translation: pos-16.0/pos-16.0-pos_lot_barcode
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_lot_barcode/es/
Currently translated at 100.0% (9 of 9 strings)

Translation: pos-16.0/pos-16.0-pos_lot_barcode
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_lot_barcode/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-17.0/pos-17.0-pos_lot_barcode
Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_lot_barcode/
Currently translated at 100.0% (6 of 6 strings)

Translation: pos-17.0/pos-17.0-pos_lot_barcode
Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_lot_barcode/fr/
Currently translated at 100.0% (6 of 6 strings)

Translation: pos-17.0/pos-17.0-pos_lot_barcode
Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_lot_barcode/it/
Currently translated at 100.0% (6 of 6 strings)

Translation: pos-17.0/pos-17.0-pos_lot_barcode
Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_lot_barcode/es/
Currently translated at 100.0% (6 of 6 strings)

Translation: pos-17.0/pos-17.0-pos_lot_barcode
Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_lot_barcode/fr/
@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Mar 18, 2025
14 tasks
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-pos_lot_barcode branch from 7f063c5 to 1bbcaf5 Compare March 18, 2025 07:32
Copy link

@Kimkhoi3010 Kimkhoi3010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BhaveshHeliconia
I failed UI test. The error "The Point of Sale can not process the scanned barcode, as it matches multiple products:" not raise
image
Can you check again because the CI tests fail.

@Kimkhoi3010
Copy link

Hi @BhaveshHeliconia, I created a PR in your repo to optimize the code. You can review and update it—please remove my commit if you merge..

Copy link

@sebduch73 sebduch73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the module and everything is ok. Can you push the PR?

@sebduch73
Copy link

@trisdoan @ivantodorovich What action must be taken to validate this module? thx

Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@ivantodorovich
Copy link
Contributor

What action must be taken to validate this module? thx

We need reviews :)

@ivantodorovich
Copy link
Contributor

Oh, I see your review is actually an approval

I tested the module and everything is ok. Can you push the PR?

Next time, try to use the Approve option when submitting, instead of "Comment", so that it's marked as approved.

Thanks!!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1337-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4fdaded into OCA:18.0 Apr 10, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7ea69e4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.