-
-
Notifications
You must be signed in to change notification settings - Fork 631
[18.0][MIG] pos_lot_barcode: Migration to 18.0. #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently translated at 100.0% (9 of 9 strings) Translation: pos-16.0/pos-16.0-pos_lot_barcode Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_lot_barcode/es/
Currently translated at 100.0% (9 of 9 strings) Translation: pos-16.0/pos-16.0-pos_lot_barcode Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_lot_barcode/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-17.0/pos-17.0-pos_lot_barcode Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_lot_barcode/
Currently translated at 100.0% (6 of 6 strings) Translation: pos-17.0/pos-17.0-pos_lot_barcode Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_lot_barcode/fr/
Currently translated at 100.0% (6 of 6 strings) Translation: pos-17.0/pos-17.0-pos_lot_barcode Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_lot_barcode/it/
Currently translated at 100.0% (6 of 6 strings) Translation: pos-17.0/pos-17.0-pos_lot_barcode Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_lot_barcode/es/
Currently translated at 100.0% (6 of 6 strings) Translation: pos-17.0/pos-17.0-pos_lot_barcode Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_lot_barcode/fr/
7f063c5
to
1bbcaf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BhaveshHeliconia
I failed UI test. The error "The Point of Sale can not process the scanned barcode, as it matches multiple products:"
not raise
Can you check again because the CI tests fail.
Hi @BhaveshHeliconia, I created a PR in your repo to optimize the code. You can review and update it—please remove my commit if you merge.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the module and everything is ok. Can you push the PR?
@trisdoan @ivantodorovich What action must be taken to validate this module? thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
We need reviews :) |
Oh, I see your review is actually an approval
Next time, try to use the Approve option when submitting, instead of "Comment", so that it's marked as approved. Thanks!! /ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 7ea69e4. Thanks a lot for contributing to OCA. ❤️ |
No description provided.